Page MenuHomePhabricator

Change ProcessGDBRemote last stop packet to a container
ClosedPublic

Authored by EwanCrawford on May 19 2015, 8:25 AM.

Details

Summary

In ProcessGDBRemote we currently have a single packet, m_last_stop_packet, used to set the thread stop info.
However in non-stop mode we can receive several stop reply packets in a sequence for different threads. As a result we need to use a container to hold them before they are processed.

This patch also changes the return type of CheckPacket() so we can detect async notification packets.

Diff Detail

Repository
rL LLVM

Event Timeline

EwanCrawford retitled this revision from to Change ProcessGDBRemote last stop packet to a container.
EwanCrawford updated this object.
EwanCrawford edited the test plan for this revision. (Show Details)
EwanCrawford added a reviewer: clayborg.
EwanCrawford set the repository for this revision to rL LLVM.
EwanCrawford added subscribers: Unknown Object (MLST), deepak2427, ted, labath.

Hi. Could you upload the patch with full context next time (git diff -U9999, or equivalent). This makes it easier to review changes in phabricator.

No problem, if anyone's interested in svn you can do 'svn diff --diff-cmd diff -x -U9999'

clayborg accepted this revision.May 26 2015, 3:23 PM
clayborg edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.May 26 2015, 3:23 PM
This revision was automatically updated to reflect the committed changes.