This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Remove spurious atomic_fetch tablegen builtins
ClosedPublic

Authored by svenvh on Mar 12 2021, 9:18 AM.

Details

Summary

The int and long versions of these builtins already provide the
necessary overloads for intptr_t and uintptr_t arguments, as
ASTContext defines atomic_(u)intptr_t in terms of the int or
long types.

Prior to this patch, calls to those builtins with particular argument
types resulted in call-is-ambiguous errors.

Diff Detail

Event Timeline

svenvh created this revision.Mar 12 2021, 9:18 AM
svenvh requested review of this revision.Mar 12 2021, 9:18 AM
Anastasia accepted this revision.Mar 17 2021, 11:02 AM

LGTM! Thanks!

This revision is now accepted and ready to land.Mar 17 2021, 11:02 AM
This revision was automatically updated to reflect the committed changes.