Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (212 w, 2 d)

Recent Activity

Wed, Oct 21

svenvh committed rGbfc961aeb2d0: [TargetLowering] Check boolean content when folding bit compare (authored by svenvh).
[TargetLowering] Check boolean content when folding bit compare
Wed, Oct 21, 3:48 AM
svenvh committed rG1af51f077b00: [TargetLowering] Add test for bit comparison fold (authored by svenvh).
[TargetLowering] Add test for bit comparison fold
Wed, Oct 21, 3:48 AM
svenvh closed D89390: [TargetLowering] Update optimization to check for boolean content.
Wed, Oct 21, 3:48 AM · Restricted Project

Fri, Oct 9

svenvh accepted D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.
Fri, Oct 9, 3:15 AM · Restricted Project

Wed, Sep 30

svenvh added a comment to D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.

LGTM! I'd suggest waiting a bit before committing this though, to give people time to catch up on the RFC.

Wed, Sep 30, 2:15 AM · Restricted Project

Aug 26 2020

svenvh accepted D86626: [OpenCL][Docs] 10.x release notes.

LGTM!

Aug 26 2020, 8:29 AM
svenvh added inline comments to D86626: [OpenCL][Docs] 10.x release notes.
Aug 26 2020, 8:11 AM

Aug 11 2020

svenvh accepted D83325: [Sema] Iteratively strip sugar when removing address spaces..

LGTM, but just wondering if the test actually belongs to this patch, as it doesn't demonstrate the problem without one of your other patches?

Aug 11 2020, 4:42 AM · Restricted Project

Jul 23 2020

svenvh added a comment to D83325: [Sema] Iteratively strip sugar when removing address spaces..

Wondering if stripping the sugar is the right thing to do here, because it means we don't have any sugar on the resulting type if it has gone through the SCS and pointer type reconstruction?

Jul 23 2020, 7:34 AM · Restricted Project

Jul 7 2020

svenvh added inline comments to D70605: [OpenCL] Fix address space for implicit conversion (PR43145).
Jul 7 2020, 10:03 AM · Restricted Project

Jun 29 2020

svenvh committed rGbd46a56474d3: [OpenCL] Reject block arguments (authored by svenvh).
[OpenCL] Reject block arguments
Jun 29 2020, 6:27 AM
svenvh closed D82313: [OpenCL] Reject block arguments.
Jun 29 2020, 6:26 AM · Restricted Project

Jun 25 2020

svenvh updated the diff for D82313: [OpenCL] Reject block arguments.

Add test case with a block as a parameter of another block.

Jun 25 2020, 1:56 AM · Restricted Project

Jun 22 2020

svenvh created D82313: [OpenCL] Reject block arguments.
Jun 22 2020, 10:12 AM · Restricted Project

May 15 2020

svenvh committed rG4549d8301842: [GlobalISel] Update GIComplexOperandMatcher comment; NFC (authored by svenvh).
[GlobalISel] Update GIComplexOperandMatcher comment; NFC
May 15 2020, 2:19 AM

Apr 29 2020

svenvh added a comment to D78979: OpenCL: Include builtin header by default.

Would it not become confusing since the builtins are going to be included by default? Should we rename the flag at least? Also ideally it should be documented in https://clang.llvm.org/docs/UsersManual.html#opencl-header

ah I guess if we leave it under -cc1 we will have the command line interface as follows:

  • Driver (without -cc1) adds OpenCL header by default that can be overridden by the flag added in this patch.
  • Frontend (with -cc1) doesn't add the header by default but there are two flags -fdeclare-opencl-builtins or -finclude-default-header that allow to include the header.
Apr 29 2020, 10:43 AM

Apr 28 2020

svenvh added a comment to D78979: OpenCL: Include builtin header by default.

Originally we didn't want to include the header by default for 2 reasons:

  1. Many vendors used their own header.
  2. It takes long time to parse the header.

However, we might be in a different position now because the header exists for long time and I think we have fixed all the issues so it should be recommended to use it instead of vendor's header. It is generally good to include it by default for the upstream user. However, I am still concerned with the parsing time. To mitigate this we have developed an alternative way to include the functions utilizing TableGen:
https://llvm.org/devmtg/2019-10/talk-abstracts.html#lit5
Unfortunately, we are not that far with testing yet to be able to use it by default. But hopefully we should be able to switch to is as a default option at some point soon.

Apr 28 2020, 4:47 AM

Apr 6 2020

svenvh abandoned D64321: [OpenCL] Change diagnostic for function declaration.

Abandoning after an offline discussion with @Anastasia. Overloading is not a feature of OpenCL C in the first place so adding complexity to Clang isn't really justifiable.

Apr 6 2020, 10:18 AM · Restricted Project, Restricted Project
svenvh commandeered D64321: [OpenCL] Change diagnostic for function declaration.
Apr 6 2020, 10:18 AM · Restricted Project, Restricted Project

Apr 2 2020

svenvh committed rG9da6a40e0999: [OpenCL] Add sub-group builtin functions (authored by svenvh).
[OpenCL] Add sub-group builtin functions
Apr 2 2020, 5:24 AM

Mar 17 2020

svenvh committed rG211ba00ce00f: [OpenCL] Add pipe and kernel enqueuing builtins (authored by svenvh).
[OpenCL] Add pipe and kernel enqueuing builtins
Mar 17 2020, 6:18 AM

Mar 12 2020

svenvh committed rG592cec7087d8: [OpenCL] Add missing get_image_array_size builtins (authored by svenvh).
[OpenCL] Add missing get_image_array_size builtins
Mar 12 2020, 7:03 AM

Mar 9 2020

svenvh committed rG25f2639fab11: [OpenCL] Fix 'any' and 'all' builtins (authored by svenvh).
[OpenCL] Fix 'any' and 'all' builtins
Mar 9 2020, 3:44 AM

Mar 6 2020

svenvh committed rG6ef953c2d649: [OpenCL] Align vload and vstore builtins (authored by svenvh).
[OpenCL] Align vload and vstore builtins
Mar 6 2020, 4:59 AM

Mar 2 2020

svenvh committed rG8a37b9e61798: [OpenCL] Remove spurious atomic_fetch_min/max builtins (authored by svenvh).
[OpenCL] Remove spurious atomic_fetch_min/max builtins
Mar 2 2020, 8:05 AM
svenvh closed D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins.
Mar 2 2020, 8:05 AM · Restricted Project

Feb 27 2020

svenvh committed rGe5cb70267e70: [ReleaseNotes] Add OpenCL release notes (authored by svenvh).
[ReleaseNotes] Add OpenCL release notes
Feb 27 2020, 9:50 AM
svenvh committed rGb65707e4818e: [ReleaseNotes] Fix typos (authored by svenvh).
[ReleaseNotes] Fix typos
Feb 27 2020, 9:50 AM
svenvh closed D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL.

Committed in e5cb70267e7.

Feb 27 2020, 8:41 AM

Feb 26 2020

svenvh accepted D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL.

LGTM

Feb 26 2020, 10:13 AM
svenvh committed rG319ea2dd9e32: [OpenCL] Add atomic type builtins (authored by svenvh).
[OpenCL] Add atomic type builtins
Feb 26 2020, 6:14 AM
svenvh added inline comments to D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL.
Feb 26 2020, 3:42 AM

Feb 20 2020

svenvh created D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins.
Feb 20 2020, 9:34 AM · Restricted Project

Feb 19 2020

svenvh committed rG81e8b60b722e: [OpenCL] Only declare _sat conversions for integer types (authored by svenvh).
[OpenCL] Only declare _sat conversions for integer types
Feb 19 2020, 5:56 AM

Feb 18 2020

svenvh committed rG8b65f792a0a9: [OpenCL] Add Arm dot product builtin functions (authored by svenvh).
[OpenCL] Add Arm dot product builtin functions
Feb 18 2020, 2:05 AM

Feb 12 2020

svenvh committed rG665dcdacc06b: Add missing newlines at EOF; NFC (authored by svenvh).
Add missing newlines at EOF; NFC
Feb 12 2020, 8:05 AM

Feb 6 2020

svenvh committed rG0fff6593f896: [OpenCL] Reduce size of builtin function tables (authored by svenvh).
[OpenCL] Reduce size of builtin function tables
Feb 6 2020, 7:13 AM

Feb 5 2020

svenvh added a comment to D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes.

I have updated the TableGen OpenCL builtin definitions accordingly in 91b3083aecd ("[OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes", 2020-02-05).

Feb 5 2020, 8:12 AM · Restricted Project
svenvh committed rG91b3083aecdc: [OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes (authored by svenvh).
[OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes
Feb 5 2020, 8:06 AM

Feb 4 2020

svenvh committed rG89b8b4218474: [OpenCL] Tidy up OpenCLBuiltins.td (authored by svenvh).
[OpenCL] Tidy up OpenCLBuiltins.td
Feb 4 2020, 3:02 AM

Jan 28 2020

svenvh added a comment to D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes.

Adding @svenvh mainly to check if any fix is needed for the TableGen BIFs too?

Jan 28 2020, 10:02 AM · Restricted Project

Jan 14 2020

svenvh accepted D72707: [clang][OpenCL] Fix covered switch warning.

Nice catch, LGTM. Thanks!

Jan 14 2020, 8:21 AM · Restricted Project
svenvh committed rG92451f0904ce: [OpenCL] Add MSAA sharing extension builtin functions (authored by svenvh).
[OpenCL] Add MSAA sharing extension builtin functions
Jan 14 2020, 6:47 AM

Jan 9 2020

svenvh committed rG241f335b268d: [OpenCL][Docs] Rename C++ for OpenCL label (authored by svenvh).
[OpenCL][Docs] Rename C++ for OpenCL label
Jan 9 2020, 8:40 AM

Jan 6 2020

svenvh accepted D72255: Fix compiler extension example cmake integration.

LGTM (for what it's worth as I'm not an expert in this area), thanks!

Jan 6 2020, 9:37 AM · Restricted Project
svenvh added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

This change seems to be causing a problem with the nightly packages from apt.llvm.org.

Jan 6 2020, 1:49 AM · Restricted Project, Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Jan 6 2020, 1:49 AM · Restricted Project

Jan 2 2020

svenvh accepted D72076: [OpenCL] Add link to C++ for OpenCL documentation.

LGTM

Jan 2 2020, 4:27 AM · Restricted Project

Dec 31 2019

svenvh committed rGff429c5eaf79: [OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC (authored by svenvh).
[OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC
Dec 31 2019, 7:33 AM

Dec 30 2019

svenvh committed rG4a188fdfa79b: [OpenCL] Add mipmap builtin functions (authored by svenvh).
[OpenCL] Add mipmap builtin functions
Dec 30 2019, 2:50 AM

Dec 23 2019

svenvh committed rGb714583fd096: [OpenCL] Add atomic builtin functions (authored by svenvh).
[OpenCL] Add atomic builtin functions
Dec 23 2019, 4:40 AM

Dec 18 2019

svenvh committed rG308b8b76ceee: [OpenCL] Add builtin function extension handling (authored by svenvh).
[OpenCL] Add builtin function extension handling
Dec 18 2019, 2:17 AM
svenvh closed D71476: [OpenCL] Add builtin function extension handling.
Dec 18 2019, 2:16 AM · Restricted Project

Dec 17 2019

svenvh added inline comments to D71476: [OpenCL] Add builtin function extension handling.
Dec 17 2019, 5:04 AM · Restricted Project
svenvh committed rGdf5a905aa8a8: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387) (authored by svenvh).
[OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)
Dec 17 2019, 3:19 AM
svenvh closed D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 17 2019, 3:19 AM · Restricted Project

Dec 13 2019

svenvh created D71476: [OpenCL] Add builtin function extension handling.
Dec 13 2019, 9:48 AM · Restricted Project

Dec 12 2019

svenvh accepted D71272: [OpenCL] Pretty print __private addr space.

LGTM.

Dec 12 2019, 10:32 AM · Restricted Project

Dec 11 2019

svenvh added inline comments to D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 11 2019, 2:13 AM · Restricted Project

Dec 9 2019

svenvh committed rGf3e6a6123264: [OpenCL] Handle address space conversions for constexpr (PR44177) (authored by svenvh).
[OpenCL] Handle address space conversions for constexpr (PR44177)
Dec 9 2019, 3:16 AM
svenvh closed D71015: [OpenCL] Handle address space conversions for constexpr (PR44177).
Dec 9 2019, 3:16 AM · Restricted Project

Dec 6 2019

svenvh created D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 6 2019, 10:41 AM · Restricted Project

Dec 4 2019

svenvh created D71015: [OpenCL] Handle address space conversions for constexpr (PR44177).
Dec 4 2019, 7:03 AM · Restricted Project

Dec 3 2019

svenvh committed rG6713670b1732: [OpenCL] Fix mangling of single-overload builtins (authored by svenvh).
[OpenCL] Fix mangling of single-overload builtins
Dec 3 2019, 3:18 AM

Dec 2 2019

svenvh committed rG62364965619b: [OpenCL] Fix address space for implicit conversion (PR43145) (authored by svenvh).
[OpenCL] Fix address space for implicit conversion (PR43145)
Dec 2 2019, 6:22 AM
svenvh closed D70605: [OpenCL] Fix address space for implicit conversion (PR43145).
Dec 2 2019, 6:21 AM · Restricted Project
svenvh added inline comments to rG9a8d477a0e00: [OpenCL] Add builtin function attribute handling.
Dec 2 2019, 4:30 AM

Nov 28 2019

svenvh updated the diff for D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Address comment from @rjmccall to preserve original ToType pointer type.

Nov 28 2019, 6:52 AM · Restricted Project

Nov 27 2019

svenvh updated the diff for D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Added test for references too.

Nov 27 2019, 9:32 AM · Restricted Project

Nov 26 2019

svenvh added a comment to D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Is there a similar problem with reference parameters?

Nov 26 2019, 7:30 AM · Restricted Project
svenvh committed rGe54c83ec4dd4: [OpenCL] Add work-group and miscellaneous vector builtin functions (authored by svenvh).
[OpenCL] Add work-group and miscellaneous vector builtin functions
Nov 26 2019, 2:53 AM

Nov 22 2019

svenvh created D70605: [OpenCL] Fix address space for implicit conversion (PR43145).
Nov 22 2019, 10:34 AM · Restricted Project

Nov 21 2019

svenvh committed rG35388dcbbc4c: [OpenCL] Fix address space for base method call (PR43145) (authored by svenvh).
[OpenCL] Fix address space for base method call (PR43145)
Nov 21 2019, 2:40 AM
svenvh closed D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 21 2019, 2:40 AM · Restricted Project

Nov 20 2019

svenvh updated the diff for D69810: [OpenCL] Fix address space for base method call (PR43145).

Incorporate suggestions from @rjmccall and add a test for the pointer case.

Nov 20 2019, 9:19 AM · Restricted Project

Nov 19 2019

svenvh updated the diff for D69810: [OpenCL] Fix address space for base method call (PR43145).

Rework fix to insert an addrspace conversion node into the AST instead of catching the addrspace cast in CGCall.

Nov 19 2019, 10:06 AM · Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Nov 19 2019, 3:29 AM · Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Nov 19 2019, 2:31 AM · Restricted Project
svenvh committed rGd56dd62a98eb: [kate] Add various missing keywords (authored by svenvh).
[kate] Add various missing keywords
Nov 19 2019, 1:56 AM

Nov 14 2019

svenvh accepted D70167: Fix use of add_llvm_tool in projects that build no targets.

LGTM!

Nov 14 2019, 2:43 AM · Restricted Project

Nov 13 2019

svenvh committed rG2fe674baa3f3: [OpenCL] Add remaining vector data builtin functions (authored by svenvh).
[OpenCL] Add remaining vector data builtin functions
Nov 13 2019, 2:24 AM

Nov 7 2019

svenvh committed rG0e70c350943f: [OpenCL] Add integer builtin functions (authored by svenvh).
[OpenCL] Add integer builtin functions
Nov 7 2019, 7:05 AM
svenvh committed rG3d30f2cff7a4: [OpenCL] Add geometric and relational builtin functions (authored by svenvh).
[OpenCL] Add geometric and relational builtin functions
Nov 7 2019, 7:05 AM
svenvh closed D69901: [OpenCL] Add integer functions to builtin functions.
Nov 7 2019, 7:04 AM · Restricted Project
svenvh closed D69908: [OpenCL] Add geometric and relational builtin functions.
Nov 7 2019, 7:04 AM · Restricted Project
svenvh committed rG6fc73f63660b: [OpenCL] Add math and common builtin functions (authored by svenvh).
[OpenCL] Add math and common builtin functions
Nov 7 2019, 5:23 AM
svenvh closed D69883: [OpenCL] Add math and common builtin functions.
Nov 7 2019, 5:23 AM · Restricted Project

Nov 6 2019

svenvh created D69908: [OpenCL] Add geometric and relational builtin functions.
Nov 6 2019, 10:09 AM · Restricted Project
svenvh created D69901: [OpenCL] Add integer functions to builtin functions.
Nov 6 2019, 9:13 AM · Restricted Project
svenvh added inline comments to D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 6 2019, 8:36 AM · Restricted Project
svenvh created D69883: [OpenCL] Add math and common builtin functions.
Nov 6 2019, 2:13 AM · Restricted Project

Nov 5 2019

svenvh committed rG0e56b0f94bfc: [OpenCL] Group builtin functions by prototype (authored by svenvh).
[OpenCL] Group builtin functions by prototype
Nov 5 2019, 2:30 AM
svenvh committed rG9a8d477a0e00: [OpenCL] Add builtin function attribute handling (authored by svenvh).
[OpenCL] Add builtin function attribute handling
Nov 5 2019, 2:30 AM
svenvh closed D63557: [OpenCL] Group builtin functions by prototype.
Nov 5 2019, 2:29 AM · Restricted Project, Restricted Project
svenvh closed D64319: [OpenCL] Add function attributes handling for builtin functions.
Nov 5 2019, 2:29 AM · Restricted Project, Restricted Project

Nov 4 2019

svenvh created D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 4 2019, 10:09 AM · Restricted Project
svenvh committed rG6c5827975cf9: [OpenCL] Fix FileCheck pattern (authored by svenvh).
[OpenCL] Fix FileCheck pattern
Nov 4 2019, 7:13 AM
svenvh committed rG82888b78d47e: [OpenCL] Fix address space for const method call from nonconst (PR43145) (authored by svenvh).
[OpenCL] Fix address space for const method call from nonconst (PR43145)
Nov 4 2019, 5:15 AM
svenvh closed D68781: [OpenCL] Fix address space for const method call from nonconst.
Nov 4 2019, 5:15 AM · Restricted Project
svenvh added inline comments to D63557: [OpenCL] Group builtin functions by prototype.
Nov 4 2019, 3:10 AM · Restricted Project, Restricted Project