Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (237 w, 6 d)

Recent Activity

Yesterday

svenvh committed rG6cb7631df348: [OpenCL] Change OpenCL builtin version encoding (authored by svenvh).
[OpenCL] Change OpenCL builtin version encoding
Mon, Apr 19, 2:24 AM
svenvh closed D100492: [OpenCL] Change OpenCL builtin version encoding.
Mon, Apr 19, 2:23 AM · Restricted Project

Fri, Apr 16

svenvh accepted D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.

LGTM, thanks!

Fri, Apr 16, 5:47 AM · Restricted Project

Thu, Apr 15

svenvh added inline comments to D100492: [OpenCL] Change OpenCL builtin version encoding.
Thu, Apr 15, 7:22 AM · Restricted Project
svenvh added inline comments to D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types.
Thu, Apr 15, 4:00 AM · Restricted Project
svenvh added inline comments to D100209: [OpenCL] Do not add builtins with unavailable types.
Thu, Apr 15, 1:50 AM · Restricted Project
svenvh updated the diff for D100209: [OpenCL] Do not add builtins with unavailable types.

Adding some more comments / explanation.

Thu, Apr 15, 1:43 AM · Restricted Project

Wed, Apr 14

svenvh requested review of D100492: [OpenCL] Change OpenCL builtin version encoding.
Wed, Apr 14, 9:11 AM · Restricted Project
svenvh committed rG856c49d79c0d: [OpenCL][Docs] Update OpenCL 3.0 implementation status (authored by svenvh).
[OpenCL][Docs] Update OpenCL 3.0 implementation status
Wed, Apr 14, 5:56 AM

Tue, Apr 13

svenvh added inline comments to D100209: [OpenCL] Do not add builtins with unavailable types.
Tue, Apr 13, 7:21 AM · Restricted Project
svenvh committed rGb757bc14e673: [OpenCL][NFC] Rename isOpenCLVersionContainedInMask (authored by svenvh).
[OpenCL][NFC] Rename isOpenCLVersionContainedInMask
Tue, Apr 13, 2:28 AM

Mon, Apr 12

svenvh committed rG731bf28a6092: [OpenCL] Accept .rgba in OpenCL 3.0 (authored by svenvh).
[OpenCL] Accept .rgba in OpenCL 3.0
Mon, Apr 12, 1:30 AM
svenvh closed D99969: [OpenCL] Accept .rgba in OpenCL 3.0.
Mon, Apr 12, 1:30 AM · Restricted Project

Fri, Apr 9

svenvh requested review of D100209: [OpenCL] Do not add builtins with unavailable types.
Fri, Apr 9, 8:38 AM · Restricted Project
svenvh committed rGaf67deb005ca: [OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable (authored by svenvh).
[OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable
Fri, Apr 9, 3:55 AM

Thu, Apr 8

svenvh committed rG8fcb114d002b: [OpenCL] Fix mipmap read_image return types (authored by svenvh).
[OpenCL] Fix mipmap read_image return types
Thu, Apr 8, 1:52 AM

Wed, Apr 7

svenvh committed rG35bc7569f8ad: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators (authored by svenvh).
[OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators
Wed, Apr 7, 2:17 AM
svenvh closed D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators.
Wed, Apr 7, 2:16 AM · Restricted Project
svenvh added a comment to D99969: [OpenCL] Accept .rgba in OpenCL 3.0.

The code formating check reported an issue though...

Wed, Apr 7, 2:09 AM · Restricted Project

Tue, Apr 6

svenvh requested review of D99969: [OpenCL] Accept .rgba in OpenCL 3.0.
Tue, Apr 6, 9:41 AM · Restricted Project

Wed, Mar 31

svenvh updated the summary of D97869: [OpenCL][Draft] Add OpenCL builtin test generator.
Wed, Mar 31, 9:29 AM
svenvh committed rGb5995fced41d: [OpenCL] Limit popcount to OpenCL 1.2 and above (authored by svenvh).
[OpenCL] Limit popcount to OpenCL 1.2 and above
Wed, Mar 31, 1:54 AM

Thu, Mar 25

svenvh committed rG8fbfc92a5cef: Reuse `os` variable in AllocateTarget; NFC (authored by svenvh).
Reuse `os` variable in AllocateTarget; NFC
Thu, Mar 25, 7:38 AM

Tue, Mar 23

svenvh updated the diff for D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

Emit #if guards for extensions and versions.

Tue, Mar 23, 7:45 AM
svenvh committed rG1c6521a0ddfa: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h (authored by svenvh).
[OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h
Tue, Mar 23, 3:21 AM
svenvh closed D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h.
Tue, Mar 23, 3:21 AM · Restricted Project

Mon, Mar 22

svenvh accepted D96771: [OpenCL] Add distinct file extension for C++ for OpenCL.

LGTM; just one minor comment, which you can address as part of your commit.

Mon, Mar 22, 5:28 AM · Restricted Project
svenvh committed rG2bbc9bccf095: [OpenCL] Support template parameters for as_type (authored by svenvh).
[OpenCL] Support template parameters for as_type
Mon, Mar 22, 4:59 AM
svenvh closed D98855: [OpenCL] Support template parameters for as_type.
Mon, Mar 22, 4:59 AM · Restricted Project
svenvh committed rG20d93267e184: [OpenCL] Use -fdeclare-opencl-builtins for some tests (authored by svenvh).
[OpenCL] Use -fdeclare-opencl-builtins for some tests
Mon, Mar 22, 2:47 AM

Mar 19 2021

svenvh requested review of D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators.
Mar 19 2021, 9:17 AM · Restricted Project

Mar 18 2021

svenvh added inline comments to D98855: [OpenCL] Support template parameters for as_type.
Mar 18 2021, 10:35 AM · Restricted Project
svenvh committed rGc5c4a88a8400: [OpenCL] Remove spurious atomic_fetch tablegen builtins (authored by svenvh).
[OpenCL] Remove spurious atomic_fetch tablegen builtins
Mar 18 2021, 5:17 AM
svenvh closed D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins.
Mar 18 2021, 5:17 AM · Restricted Project
svenvh requested review of D98855: [OpenCL] Support template parameters for as_type.
Mar 18 2021, 4:54 AM · Restricted Project

Mar 16 2021

svenvh added a comment to D96771: [OpenCL] Add distinct file extension for C++ for OpenCL.

I had a second thought about the extension name and I realized that the reason why I initially wanted to use clcpp is that it aligns better with clc++ which is used in -cl-std. Even though from the RFC the preference was towards cppcl it felt like there was no objection to clcpp either. So I just want to check one last time whether it would make sense to align with clc++ and use clcpp. Perhaps, it make clang interface a bit more inconsistent?

Mar 16 2021, 5:16 AM · Restricted Project

Mar 12 2021

svenvh added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Does it repro if you add -target arm64-apple-macosx as arg to c-index-test on the RUN line of that test?

Mar 12 2021, 10:09 AM · Restricted Project
svenvh requested review of D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins.
Mar 12 2021, 9:18 AM · Restricted Project
svenvh accepted D98411: [OpenCL] Respect calling convention for builtin .
Mar 12 2021, 5:41 AM · Restricted Project

Mar 11 2021

svenvh accepted D98076: [OpenCL][Docs] Release 12.0 notes .

Sorry for the last-minute change, I have decided to add this too:

+- Removed extensions without kernel language changes:
+  ``cl_khr_select_fprounding_mode``, ``cl_khr_gl_sharing``, ``cl_khr_icd``,
+  ``cl_khr_gl_event``, ``cl_khr_d3d10_sharing``, ``cl_khr_context_abort``,
+  ``cl_khr_d3d11_sharing``, ``cl_khr_dx9_media_sharing``,
+  ``cl_khr_image2d_from_buffer``, ``cl_khr_initialize_memory``,
+  ``cl_khr_gl_depth_images``, ``cl_khr_spir``, ``cl_khr_egl_event``,
+  ``cl_khr_egl_image``, ``cl_khr_terminate_context``.
Mar 11 2021, 5:58 AM
svenvh requested review of D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h.
Mar 11 2021, 5:45 AM · Restricted Project
svenvh committed rGdcdd476c46dc: [OpenCL] Add missing atomic_xchg overload (authored by svenvh).
[OpenCL] Add missing atomic_xchg overload
Mar 11 2021, 2:21 AM

Mar 10 2021

svenvh accepted D98076: [OpenCL][Docs] Release 12.0 notes .
Mar 10 2021, 8:36 AM
svenvh added a comment to D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

Regarding 2 and 4 I think we should drive towards deprecation of opencl-c.h as it is a maintenance overhead but we could convert it into a test instead?

Mar 10 2021, 8:35 AM
svenvh added inline comments to D98076: [OpenCL][Docs] Release 12.0 notes .
Mar 10 2021, 6:44 AM
svenvh added inline comments to D98076: [OpenCL][Docs] Release 12.0 notes .
Mar 10 2021, 6:36 AM
svenvh accepted D96771: [OpenCL] Add distinct file extension for C++ for OpenCL.

LGTM, but maybe give this another 24h before landing in case there are any remaining concerns.

Mar 10 2021, 5:32 AM · Restricted Project
svenvh accepted D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features.

LGTM with the latest elaboration on "useful". It seems you accidentally added unrelated changes to Types.cpp to this review, so please take care not to commit those.

Mar 10 2021, 3:59 AM · Restricted Project
svenvh committed rG6f912a2cd491: [OpenCL] Set calling convention for -fdeclare-opencl-builtins (authored by svenvh).
[OpenCL] Set calling convention for -fdeclare-opencl-builtins
Mar 10 2021, 2:05 AM
svenvh closed D98039: [OpenCL] Set calling convention for -fdeclare-opencl-builtins.
Mar 10 2021, 2:05 AM · Restricted Project

Mar 9 2021

svenvh added inline comments to D98076: [OpenCL][Docs] Release 12.0 notes .
Mar 9 2021, 3:51 AM
svenvh committed rG13c77f204671: [OpenCL] Fix builtins that require multiple extensions (authored by svenvh).
[OpenCL] Fix builtins that require multiple extensions
Mar 9 2021, 3:38 AM
svenvh closed D97930: [OpenCL] Fix builtins that require multiple extensions.
Mar 9 2021, 3:38 AM · Restricted Project

Mar 5 2021

svenvh updated the diff for D97930: [OpenCL] Fix builtins that require multiple extensions.

You don't seem to be using write_imagef for OpenCL versions <= 1.2. But should we be checking that the diagnostic is given?

Mar 5 2021, 9:13 AM · Restricted Project
svenvh added a comment to D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

To be honest, I don't have a concrete picture yet of how to deploy this emitter for testing. So here are a few thoughts about the various options that come to mind:

Mar 5 2021, 7:27 AM
svenvh requested review of D98039: [OpenCL] Set calling convention for -fdeclare-opencl-builtins.
Mar 5 2021, 5:54 AM · Restricted Project
svenvh committed rGf0686569cc57: [OpenCL] Fix `mix` builtin overloads (authored by svenvh).
[OpenCL] Fix `mix` builtin overloads
Mar 5 2021, 5:45 AM

Mar 4 2021

svenvh added a comment to D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

I was just thinking if we could combine the calls into one function to minimize the number of lines to parse? Perhaps this will make the Tablegen generator too complex?

Mar 4 2021, 4:11 AM
svenvh requested review of D97930: [OpenCL] Fix builtins that require multiple extensions.
Mar 4 2021, 3:59 AM · Restricted Project

Mar 3 2021

svenvh updated the summary of D97869: [OpenCL][Draft] Add OpenCL builtin test generator.
Mar 3 2021, 9:28 AM
svenvh requested review of D97869: [OpenCL][Draft] Add OpenCL builtin test generator.
Mar 3 2021, 9:26 AM

Mar 2 2021

svenvh added a comment to D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features.

LGTM mostly, but would like to hear the opinion of others on the discussion about "useful".

Mar 2 2021, 3:51 AM · Restricted Project
svenvh accepted D97725: [OpenCL] Add const attribute to ctz() builtin.

LGTM, thanks!

Mar 2 2021, 2:26 AM · Restricted Project, Restricted Project
svenvh committed rG3fa0e793729a: [OpenCL] Use StringMap instead of std::map (authored by svenvh).
[OpenCL] Use StringMap instead of std::map
Mar 2 2021, 1:39 AM

Feb 24 2021

svenvh added inline comments to D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features.
Feb 24 2021, 9:38 AM · Restricted Project
svenvh added a comment to D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features.

Some minor typos and requests for clarifications, looks like reasonable guidelines other than that.

Feb 24 2021, 1:55 AM · Restricted Project
svenvh committed rG0344aea6ea37: [OpenCL] Add ndrange builtin functions to TableGen (authored by svenvh).
[OpenCL] Add ndrange builtin functions to TableGen
Feb 24 2021, 1:33 AM
svenvh committed rG85eb12eefdf6: [OpenCL] Add declarations with enum/typedef args (authored by svenvh).
[OpenCL] Add declarations with enum/typedef args
Feb 24 2021, 1:33 AM
svenvh closed D97060: [OpenCL] Add ndrange builtin functions to TableGen.
Feb 24 2021, 1:33 AM · Restricted Project
svenvh closed D96860: [OpenCL] Add declarations with enum/typedef args.
Feb 24 2021, 1:33 AM · Restricted Project

Feb 23 2021

svenvh added inline comments to D96860: [OpenCL] Add declarations with enum/typedef args.
Feb 23 2021, 7:32 AM · Restricted Project
svenvh updated the diff for D96860: [OpenCL] Add declarations with enum/typedef args.

Add comment about get_fence.

Feb 23 2021, 7:03 AM · Restricted Project
svenvh committed rG612d0ef1732f: [OpenCL] Move remaining defines to opencl-c-base.h (authored by svenvh).
[OpenCL] Move remaining defines to opencl-c-base.h
Feb 23 2021, 2:19 AM
svenvh closed D96948: [OpenCL] Move remaining defines to opencl-c-base.h.
Feb 23 2021, 2:18 AM · Restricted Project

Feb 19 2021

svenvh added inline comments to D97052: [OpenCL] Prevent adding extension pragma by default.
Feb 19 2021, 9:24 AM · Restricted Project
svenvh requested review of D97060: [OpenCL] Add ndrange builtin functions to TableGen.
Feb 19 2021, 9:11 AM · Restricted Project
svenvh added inline comments to D96860: [OpenCL] Add declarations with enum/typedef args.
Feb 19 2021, 9:02 AM · Restricted Project
svenvh added a comment to D96948: [OpenCL] Move remaining defines to opencl-c-base.h.

LGTM! Btw since we are moving this code anyway, do you think we could fix the formatting?

Feb 19 2021, 6:24 AM · Restricted Project

Feb 18 2021

svenvh accepted D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers.

LGTM!

Feb 18 2021, 8:37 AM · Restricted Project
svenvh requested review of D96948: [OpenCL] Move remaining defines to opencl-c-base.h.
Feb 18 2021, 3:35 AM · Restricted Project
svenvh committed rG5a4a01460f1a: [OpenCL] Move printf declaration to opencl-c-base.h (authored by svenvh).
[OpenCL] Move printf declaration to opencl-c-base.h
Feb 18 2021, 3:28 AM
svenvh closed D96789: [OpenCL] Move printf declaration to opencl-c-base.h.
Feb 18 2021, 3:28 AM · Restricted Project

Feb 17 2021

svenvh accepted D96515: [OpenCL] Add builtin declarations by default..

LGTM

Feb 17 2021, 9:52 AM · Restricted Project
svenvh committed rG23d65aa44631: [OpenCL] Support enum and typedef args in TableGen BIFs (authored by svenvh).
[OpenCL] Support enum and typedef args in TableGen BIFs
Feb 17 2021, 6:18 AM
svenvh closed D96051: [OpenCL] Support enum and typedef args in TableGen BIFs.
Feb 17 2021, 6:17 AM · Restricted Project
svenvh requested review of D96860: [OpenCL] Add declarations with enum/typedef args.
Feb 17 2021, 4:42 AM · Restricted Project

Feb 16 2021

svenvh added inline comments to D96771: [OpenCL] Add distinct file extension for C++ for OpenCL.
Feb 16 2021, 8:53 AM · Restricted Project
svenvh requested review of D96789: [OpenCL] Move printf declaration to opencl-c-base.h.
Feb 16 2021, 7:10 AM · Restricted Project
svenvh added inline comments to D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers.
Feb 16 2021, 6:31 AM · Restricted Project

Feb 12 2021

svenvh added inline comments to D96051: [OpenCL] Support enum and typedef args in TableGen BIFs.
Feb 12 2021, 9:21 AM · Restricted Project
svenvh added inline comments to D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.
Feb 12 2021, 3:41 AM · Restricted Project
svenvh added a comment to D96515: [OpenCL] Add builtin declarations by default..

It probably makes sense to update clang/docs/UsersManual.rst as part of this change. In particular the following sentence is no longer true after this patch: "By default the OpenCL headers are not loaded and therefore certain builtin types and most of builtin functions are not declared."

Feb 12 2021, 3:23 AM · Restricted Project
svenvh requested review of D96588: [OpenCL] Remove FIXME in getOpenCLFeatureDefines.
Feb 12 2021, 3:13 AM · Restricted Project
svenvh committed rG18f16c945f52: [OpenCL][Docs] Clean up trailing characters (authored by svenvh).
[OpenCL][Docs] Clean up trailing characters
Feb 12 2021, 2:03 AM
svenvh committed rG18a70797e798: [OpenCL][Docs] Describe internals of TableGen builtins (authored by svenvh).
[OpenCL][Docs] Describe internals of TableGen builtins
Feb 12 2021, 2:03 AM
svenvh closed D96150: [OpenCL][Docs] Describe internals of TableGen BIFs.
Feb 12 2021, 2:03 AM · Restricted Project

Feb 11 2021

svenvh updated the diff for D96051: [OpenCL] Support enum and typedef args in TableGen BIFs.

Add test for new diagnostic.

Feb 11 2021, 8:52 AM · Restricted Project
svenvh committed rG3a29ac2a61f7: [OpenCL] Fix missing const attributes for get_image_ builtins (authored by svenvh).
[OpenCL] Fix missing const attributes for get_image_ builtins
Feb 11 2021, 5:07 AM
svenvh committed rG0b448854daff: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs (authored by svenvh).
[OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs
Feb 11 2021, 1:33 AM
svenvh closed D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs.
Feb 11 2021, 1:33 AM · Restricted Project