This is an archive of the discontinued LLVM Phabricator instance.

Implement attach to process on windows
ClosedPublic

Authored by zturner on May 15 2015, 3:41 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 25897.May 15 2015, 3:41 PM
zturner retitled this revision from to Implement attach to process on windows.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: amccarth.
zturner added a subscriber: Unknown Object (MLST).
zturner updated this revision to Diff 25903.May 15 2015, 4:27 PM

Add context

amccarth edited edge metadata.May 15 2015, 4:44 PM

My biggest concern is making the key explanation in the comments a little clearer. Other than that, this looks pretty good.

source/Plugins/Platform/Windows/PlatformWindows.cpp
535 ↗(On Diff #25897)

I'm confused here. If you're attaching to a process that's already running, we can't spawn the process. Are you're talking only about launching and not "launching _or attaching_ to a process"?

541 ↗(On Diff #25897)

s/it to stop/it stop/

545 ↗(On Diff #25897)

s/into/in/

source/Plugins/Platform/Windows/PlatformWindows.h
124 ↗(On Diff #25897)

Isn't the LLDB style to put the return type on a separate line?

source/Plugins/Process/Windows/ProcessWindows.cpp
347 ↗(On Diff #25897)

I wonder if we should have some sort of finite timeout here. If something goes wrong, it would be nice for tests to fail rather than hang.

This revision was automatically updated to reflect the committed changes.