Enable workaround for finding functions in global namespace on linux binaries on all hosts.

[flackr]

Summary

We require a workaround to be able to locate global and anonymous namespace functions in the dwarf symbols on linux binaries. This patch enables this code on all platforms so that we can still find these symbols when debugging from a different host platform.

[clayborg]

Looks good.

[ted]

This affects Windows and Hexagon as well, FYI. I believe this will fix bug 22177.

[zturner]

lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

4054–4055

This check is only meaningful under a particular ABI. Could you check the triple or ArchSpec of the target you're looking at first, and either not do this if the triple contains MSVC (or better yet, add a correct check)?

[flackr]

lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

4054–4055

Hey, I added a check that the object file is linux or freebsd: http://reviews.llvm.org/D9782. I tried to add a check for windows arch as well, but the arch was not correctly recognized in my tests, I was seeing i386-unknown-unknown. Let me know if you know where I might be able to find the target arch instead if not through the object file and I'm happy to add a correct Windows check as well. Thanks.

[zturner]

If it's not correct in the object file I think the best fix is to make it
correct in the object file. I actually had to fix a few things like that
in the past. Either way, don't worry about it. I will get around to it
eventually :) Maybe a comment saying // TODO: The arch in the object file
isn't correct for MSVC binaries on windows, so we should find a way to make
it correct.

lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

else
         if (!m_indexed)
             Index ();
 
         if (name_type_mask & eFunctionNameTypeFull)
         {
             FindFunctions (name, m_function_fullname_index, include_inlines, sc_list);
 
             // FIXME Temporary workaround for global/anonymous namespace
-            // functions on FreeBSD and Linux
-#if defined (__FreeBSD__) || defined (__linux__)
+            // functions debugging FreeBSD and Linux binaries.
             // If we didn't find any functions in the global namespace try
             // looking in the basename index but ignore any returned
             // functions that have a namespace (ie. mangled names starting with 
             // '_ZN') but keep functions which have an anonymous namespace
             if (sc_list.GetSize() == 0)
             {
                 SymbolContextList temp_sc_list;
                 FindFunctions (name, m_function_basename_index, include_inlines, temp_sc_list);
                 if (!namespace_decl)
                 {
                     SymbolContext sc;
                     for (uint32_t i = 0; i < temp_sc_list.GetSize(); i++)
                     {
                         if (temp_sc_list.GetContextAtIndex(i, sc))
                         {
                             ConstString mangled_name = sc.GetFunctionName(Mangled::ePreferMangled);
                             ConstString demangled_name = sc.GetFunctionName(Mangled::ePreferDemangled);
                             if (strncmp(mangled_name.GetCString(), "_ZN", 3) ||
                                 !strncmp(demangled_name.GetCString(), "(anonymous namespace)", 21))
                             {
                                 sc_list.Append(sc);
                             }
                         }
                     }
                 }
             }
-#endif
         }
         DIEArray die_offsets;
         DWARFCompileUnit *dwarf_cu = NULL;
         
         if (name_type_mask & eFunctionNameTypeBase)
         {
             uint32_t num_base = m_function_basename_index.Find(name, die_offsets);
             for (uint32_t i = 0; i < num_base; i++)