This is an archive of the discontinued LLVM Phabricator instance.

Make EmitFunctionHeader virtual
ClosedPublic

Authored by arsenm on May 11 2015, 12:23 PM.

Details

Reviewers
rafael
Summary

This is to fix problems introduced by r232481. For HSAIL,
this function does essentially nothing desirable, and
injects unwanted / incorrect stuff before the function.
The only thing it really needs to do is call EmitFunctionEntryLabel
in this case.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 25496.May 11 2015, 12:23 PM
arsenm retitled this revision from to Make EmitFunctionHeader virtual .
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a reviewer: rafael.
arsenm added a subscriber: Unknown Object (MLST).
rafael accepted this revision.May 22 2015, 4:39 PM
rafael edited edge metadata.

LGTM with the condition that the HSAIL backend will show up soon :-)

This revision is now accepted and ready to land.May 22 2015, 4:39 PM
arsenm closed this revision.May 26 2015, 10:37 AM

r238222.

HSAIL is already posted to http://reviews.llvm.org/D9751!