This is an archive of the discontinued LLVM Phabricator instance.

Move logic from JumpThreading into LazyValue info to simplify caller.
ClosedPublic

Authored by reames on May 10 2015, 8:00 PM.

Details

Summary

This change is hopefully NFC. The only tricky part is that I changed the context instruction being used to the branch rather than the comparison. I believe both to be correct, but the branch is strictly more powerful. With the moved code, using the branch instruction is required for the basic block comparison test to return the same result. The previous code was able to directly access both the branch and the comparison where the revised code is not.

Diff Detail

Event Timeline

reames updated this revision to Diff 25438.May 10 2015, 8:00 PM
reames retitled this revision from to Move logic from JumpThreading into LazyValue info to simplify caller. .
reames updated this object.
reames edited the test plan for this revision. (Show Details)
reames added reviewers: hfinkel, apilipenko.
reames added a subscriber: Unknown Object (MLST).
apilipenko accepted this revision.May 14 2015, 7:17 AM
apilipenko edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 14 2015, 7:17 AM
This revision was automatically updated to reflect the committed changes.