Do not include pthread.h and sched.h when threads are disabled

[blastrock]

Summary

When compiling with LIBCXX_ENABLE_THREADS=NO, it still tries to include those, even though it doesn't need them.

[blastrock]

Do not include pthread.h and sched.h when threads are disabled

Subscribers: cfe-commits

[danalbert]

This LGTM, but I'm confused why @jroelofs hasn't needed it already.

[jroelofs]

I get away with not having the guard in <__mutex_base> because all the places where these two headers are used have:

#ifdef _LIBCPP_HAS_NO_THREADS
#error <thread> is not supported on this single threaded system
#else // !_LIBCPP_HAS_NO_THREADS

The one in mutex, I think, is a result of me not having rebased in a _long_ time, and the buildbot for it not testing exactly the same setup as me.

[jroelofs]

@blastrock have you committed this yet?

[blastrock]

Sorry, I'm not sure I got what is the workflow on this platform. This patch is now "accepted", but do I need to do something else here? The only relevant action I can do seems to be "close revision", should I do that?

The developper policy page does not seem to indicate what to do after a patch has been accepted (or did I miss it?).

[jroelofs]

Ah, usually the process is that you get your patch through review, and when someone accepts it, then you can commit it. If you do not have commit rights, then you can get someone else to commit it for you.

Accepted => "ok to commit"
Closed => "I've committed it"

Do you need me to commit it for you?

[blastrock]

Oh I see! Indeed, I don't have commit rights, so I would help me if you could do it :)

[jroelofs]

r246168

[blastrock]

Thank you!

include/__mutex_base

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef _LIBCPP___MUTEX_BASE
 #define _LIBCPP___MUTEX_BASE
 
 #include <__config>
 #include <chrono>
 #include <system_error>
+#ifndef _LIBCPP_HAS_NO_THREADS
 #include <pthread.h>
+#endif
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #pragma GCC system_header
 #endif
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 #ifndef _LIBCPP_HAS_NO_THREADS

include/mutex

 */
 
 #include <__config>
 #include <__mutex_base>
 #include <functional>
 #ifndef _LIBCPP_HAS_NO_VARIADICS
 #include <tuple>
 #endif
+#ifndef _LIBCPP_HAS_NO_THREADS
 #include <sched.h>
+#endif
 
 #include <__undef_min_max>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #pragma GCC system_header
 #endif
 
 _LIBCPP_BEGIN_NAMESPACE_STD