This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Adding test for clobbering of high registers in Thumb
ClosedPublic

Authored by pratlucas on Feb 9 2021, 6:13 AM.

Details

Summary

Prior to the changes from D52010, clobbering Thumb's high registers in
inline asm would cause incorrect code to be generated - or an assertion
failure for debug builds. Now that the issue is no longer reproducible,
this patch adds a MIR test to cover that scenario.

Diff Detail

Event Timeline

pratlucas requested review of this revision.Feb 9 2021, 6:13 AM
pratlucas created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 6:13 AM
arsenm added inline comments.Feb 11 2021, 3:41 PM
llvm/test/CodeGen/Thumb/high-reg-clobber.mir
7–22

You can drop the IR section

pratlucas updated this revision to Diff 323768.Feb 15 2021, 8:23 AM

Dropping test's IR section.

pratlucas marked an inline comment as done.Feb 15 2021, 8:23 AM
arsenm accepted this revision.Feb 24 2021, 6:13 AM

LGTM

llvm/test/CodeGen/Thumb/high-reg-clobber.mir
12–17

Can drop this too

This revision is now accepted and ready to land.Feb 24 2021, 6:13 AM