This is an archive of the discontinued LLVM Phabricator instance.

[TestWatchpointMultipleThreads] Use default test executable names.
ClosedPublic

Authored by sivachandra on May 6 2015, 3:57 PM.

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 25102.May 6 2015, 3:57 PM
sivachandra retitled this revision from to [TestWatchpointMultipleThreads] Use shorter exe names to satisfy Android.
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added a reviewer: chaoren.
sivachandra added a subscriber: Unknown Object (MLST).
chaoren added inline comments.May 6 2015, 4:02 PM
test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
52–53

Why not just use a.out for every executable. If we enforce this rule, we can avoid similar problems in the future too.

tberghammer added inline comments.May 7 2015, 3:21 AM
test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
52–53

I agree with changing all executable names to a.out as the name conflicts are already solved with creating a new directory for each test case

Use default exe name of a.out for the test cases.

chaoren accepted this revision.May 7 2015, 12:23 PM
chaoren edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 12:23 PM
sivachandra retitled this revision from [TestWatchpointMultipleThreads] Use shorter exe names to satisfy Android to [TestWatchpointMultipleThreads] Use default test executable names..May 7 2015, 12:31 PM
sivachandra edited edge metadata.
sivachandra closed this revision.May 7 2015, 2:59 PM