This is an archive of the discontinued LLVM Phabricator instance.

[hip] Fix `<complex>` compilation on Windows with VS2019.
ClosedPublic

Authored by hliao on Jan 20 2021, 11:56 AM.

Diff Detail

Event Timeline

hliao requested review of this revision.Jan 20 2021, 11:56 AM
hliao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 11:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hliao updated this revision to Diff 317966.Jan 20 2021, 12:10 PM

Fix typo.

yaxunl accepted this revision.Jan 20 2021, 1:09 PM
This revision is now accepted and ready to land.Jan 20 2021, 1:09 PM
This revision was landed with ongoing or failed builds.Jan 20 2021, 1:44 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a subscriber: MaskRay.EditedJan 26 2021, 9:21 AM

In your commit the message does not include Reviewed by:. Many people agree that both Reviewed by: & Differential Revision: should be present. The Reviewed by: list indicates people who acknowledged the patch. (The Reviewers: list does not necessarily mean all the people on the list have acknowledged the patch so Reviewers: is mostly useless.)

arc amend can fetch the Phabricator summary and amend the local description.

You can install llvm/utils/git/pre-push.py to prevent accidental Summary:, Reviewers:, Subscribers: and Tags: in the presence of Differential Revision:.