Replace the broken LambdaCapture::isInitCapture API.

[jdennett]

Summary

A LambdaCapture does not have sufficient information
to correctly determine whether it is an init-capture or not.
Doing so requires knowledge held in the LambdaExpr itself.

It the case of a nested capture of an init-capture it is not
sufficient to check (as LambdaCapture::isInitCapture
did) whether the associated VarDecl was from an init-capture.

This patch moves isInitCapture to the LambdaExpr and updates
capture->isInitCapture() to lambda->isInitCapture(capture).

[jdennett]

Added tests, and fixed the fix.

Clang ToT rejects the (valid) code from the testcase. With this patch,
it is accepted (and works as intended).

[jdennett]

Actually add the test.

[jdennett]

Coding style fix: change parameter name from capture to Capture.

[jdennett]

Fixing formatting.

[rsmith]

LGTM

[jdennett]

Improve formatting of lambda functions.

Don't let the trailing '*' of a lambda's explicitly-specified return
type be immediately adjacent to the left brace that starts the body
of the lambda.

[jdennett]

That last patch was me losing a fight with arc. The clang-format patch is http://reviews.llvm.org/D10410. This one really is closed.

lib/Format/TokenAnnotator.cpp

if (Right.is(TT_TemplateOpener) && Left.is(tok::r_paren) &&
     return false;
   if (Right.is(tok::less) && Left.isNot(tok::l_paren) &&
       Line.First->is(tok::hash))
     return true;
   if (Right.is(TT_TrailingUnaryOperator))
     return false;
   if (Left.is(TT_RegexLiteral))
     return false;
+
+  // `[]() -> T *{` needs a space inserted before the left brace.
+  if (Left.is(TT_PointerOrReference) && Right.is(tok::l_brace))
+    return true;
+
   return spaceRequiredBetween(Line, Left, Right);
 }
 
 // Returns 'true' if 'Tok' is a brace we'd want to break before in Allman style.
 static bool isAllmanBrace(const FormatToken &Tok) {
   return Tok.is(tok::l_brace) && Tok.BlockKind == BK_Block &&
          !Tok.isOneOf(TT_ObjCBlockLBrace, TT_DictLiteral);
 }

unittests/Format/FormatTest.cpp

EXPECT_EQ("int i;\n"
                    "   int   k;"));
 }
 
 TEST_F(FormatTest, DoNotCrashOnInvalidInput) {
   format("? ) =");
   verifyNoCrash("#define a\\\n /**/}");
 }
 
+TEST_F(FormatTest, IncludeSpaceBeforeLambdaBody) {
+  verifyFormat("int *p = []() -> int * { return nullptr; }();");
+}
+
 } // end namespace tooling
 } // end namespace clang