This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Make an argument optional in RFV::getCopyToRegs. NFC.
ClosedPublic

Authored by sanjoy on May 4 2015, 10:43 AM.

Download Raw Diff

Details

Reviewers

reames
atrick

Commits

rG1194d1e799c7: [SelectionDAG] Make an argument optional in RFV::getCopyToRegs. NFC.
rL236555: [SelectionDAG] Make an argument optional in RFV::getCopyToRegs. NFC.

Summary

We default the value argument to nullptr. The only use of the value is
in diagnosePossiblyInvalidConstraint and that seems to be resilient to
it being nullptr.

Diff Detail

Repository: rL LLVM

Event Timeline

sanjoy updated this revision to Diff 24894.May 4 2015, 10:43 AM

sanjoy retitled this revision from to [SelectionDAG] Make an argument optional in RFV::getCopyToRegs. NFC..

sanjoy updated this object.

sanjoy edited the test plan for this revision. (Show Details)

sanjoy added reviewers: atrick, reames.

sanjoy added a subscriber: Unknown Object (MLST).

Makes sense.

This revision is now accepted and ready to land.May 4 2015, 11:58 AM

Closed by commit rL236555: [SelectionDAG] Make an argument optional in RFV::getCopyToRegs. NFC. (authored by sanjoy). · Explain WhyMay 5 2015, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

CodeGen/

SelectionDAG/

SelectionDAGBuilder.h

11 lines

Diff 24994

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

Show First 20 Lines • Show All 929 Lines • ▼ Show 20 Lines	struct RegsForValue {
/// this value and returns the result as a ValueVTs value. This uses		/// this value and returns the result as a ValueVTs value. This uses
/// Chain/Flag as the input and updates them for the output Chain/Flag.		/// Chain/Flag as the input and updates them for the output Chain/Flag.
/// If the Flag pointer is NULL, no flag is used.		/// If the Flag pointer is NULL, no flag is used.
SDValue getCopyFromRegs(SelectionDAG &DAG, FunctionLoweringInfo &FuncInfo,		SDValue getCopyFromRegs(SelectionDAG &DAG, FunctionLoweringInfo &FuncInfo,
SDLoc dl,		SDLoc dl,
SDValue &Chain, SDValue *Flag,		SDValue &Chain, SDValue *Flag,
const Value *V = nullptr) const;		const Value *V = nullptr) const;

/// getCopyToRegs - Emit a series of CopyToReg nodes that copies the		/// getCopyToRegs - Emit a series of CopyToReg nodes that copies the specified
/// specified value into the registers specified by this object. This uses		/// value into the registers specified by this object. This uses Chain/Flag
/// Chain/Flag as the input and updates them for the output Chain/Flag.		/// as the input and updates them for the output Chain/Flag. If the Flag
/// If the Flag pointer is NULL, no flag is used.		/// pointer is nullptr, no flag is used. If V is not nullptr, then it is used
		/// in printing better diagnostic messages on error.
void		void
getCopyToRegs(SDValue Val, SelectionDAG &DAG, SDLoc dl, SDValue &Chain,		getCopyToRegs(SDValue Val, SelectionDAG &DAG, SDLoc dl, SDValue &Chain,
SDValue Flag, const Value V,		SDValue Flag, const Value V = nullptr,
ISD::NodeType PreferredExtendType = ISD::ANY_EXTEND) const;		ISD::NodeType PreferredExtendType = ISD::ANY_EXTEND) const;

/// AddInlineAsmOperands - Add this value to the specified inlineasm node		/// AddInlineAsmOperands - Add this value to the specified inlineasm node
/// operand list. This adds the code marker, matching input operand index		/// operand list. This adds the code marker, matching input operand index
/// (if applicable), and includes the number of values added into it.		/// (if applicable), and includes the number of values added into it.
void AddInlineAsmOperands(unsigned Kind,		void AddInlineAsmOperands(unsigned Kind,
bool HasMatching, unsigned MatchingIdx, SDLoc dl,		bool HasMatching, unsigned MatchingIdx, SDLoc dl,
SelectionDAG &DAG,		SelectionDAG &DAG,
std::vector<SDValue> &Ops) const;		std::vector<SDValue> &Ops) const;
};		};

} // end namespace llvm		} // end namespace llvm

#endif		#endif