This is an archive of the discontinued LLVM Phabricator instance.

Have `__have_extension(cxx_variadic_templates)` return true for any C++ standard.
ClosedPublic

Authored by EricWF on Apr 30 2015, 6:59 PM.

Details

Reviewers
majnemer
rsmith
Summary

Currently __has_extension(cxx_variadic_templates) always evaluates to 0 even though the front-end accepts the extension.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 24787.Apr 30 2015, 6:59 PM
EricWF retitled this revision from to Have `__have_extension(cxx_variadic_templates)` return true for any C++ standard..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: rsmith, majnemer.
EricWF added a subscriber: Unknown Object (MLST).

Gentle ping. This is a tiny change but I don't work on clang so I would really like a thumbs up.

rsmith accepted this revision.May 12 2015, 2:11 PM
rsmith edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 12 2015, 2:11 PM
rsmith added inline comments.May 12 2015, 2:12 PM
lib/Lex/PPMacroExpansion.cpp
1239

Please keep this list alphabetized.

EricWF updated this revision to Diff 25631.May 12 2015, 2:26 PM
EricWF edited edge metadata.

Alphabetize entry in list.

EricWF closed this revision.May 12 2015, 3:41 PM

Closed in r237202.