This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add definitions for 5.1 interop to omp.h
AcceptedPublic

Authored by hbae on Dec 16 2020, 4:41 PM.

Details

Summary

Added definitions for 5.1 interop to omp.h.

Diff Detail

Event Timeline

hbae created this revision.Dec 16 2020, 4:41 PM
hbae requested review of this revision.Dec 16 2020, 4:41 PM

Cool! I'm really happy to see this.

Given that we have a doxygen documentation for openmp now (not yet online but it can be build), we should start adding appropriate comments, especially to user facing functions. That should also give them information right in the IDE, which is arguably good.

That said, this file is used to create omp.h, right? If so, we should copy the description from the OpenMP standard here. Summary, maybe all of it.


FWIW, an early prototype can be found here https://github.com/jdoerfert/llvm-project/commit/c514fc3bfc22bee958f9aedde56dafee642bd381

openmp/runtime/src/include/omp.h.var
169

Let's move it above the enum /// ...

172

Do we really want/need to define it or can we provide a constant variable, nicer for debugging I think.

hbae updated this revision to Diff 312514.Dec 17 2020, 8:26 AM

Copied summary of the interop routines from the spec.

hbae marked an inline comment as done.Dec 17 2020, 8:31 AM
hbae added inline comments.
openmp/runtime/src/include/omp.h.var
172

I prefer defining it, and we also have similar definitions in omp-tools.h.var.

jdoerfert accepted this revision.Dec 17 2020, 8:42 AM

LGTM, thanks for the comments.

This revision is now accepted and ready to land.Dec 17 2020, 8:42 AM