Page MenuHomePhabricator
Differential D93417

[libc] Refactor WrapperGen to make the flow cleaner.
ClosedPublic
Actions

Authored by sivachandra on Dec 16 2020, 1:07 PM.

Details

Reviewers
michaelrj
Commits
rGbf03eba1f99b: [libc] Refactor WrapperGen to make the flow cleaner.

Diff Detail

Event Timeline

sivachandra created this revision.Dec 16 2020, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2020, 1:07 PM
Herald added subscribers: libc-commits, ecnelises, tschuett, jfb. · View Herald Transcript
sivachandra requested review of this revision.Dec 16 2020, 1:07 PM
Harbormaster completed remote builds in B82682: Diff 312289.Dec 16 2020, 1:42 PM
michaelrj accepted this revision.Dec 16 2020, 3:43 PM

accepted with nits

libc/utils/tools/WrapperGen/Main.cpp
54

Nit: Exactly

59

Nit: simultaneously

68

Nit: At least

This revision is now accepted and ready to land.Dec 16 2020, 3:43 PM
sivachandra updated this revision to Diff 312523.Thu, Dec 17, 8:55 AM
sivachandra marked 3 inline comments as done.

Fix nits.

sivachandra added a comment.Thu, Dec 17, 8:56 AM

Addressed comments.

This revision was landed with ongoing or failed builds.Thu, Dec 17, 8:57 AM
Closed by commit rGbf03eba1f99b: [libc] Refactor WrapperGen to make the flow cleaner. (authored by sivachandra). · Explain Why
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rGbf03eba1f99b: [libc] Refactor WrapperGen to make the flow cleaner..
Harbormaster completed remote builds in B82812: Diff 312523.Thu, Dec 17, 10:21 AM

Revision Contents
Changeset List

PathSize
libc/
test/
utils/
tools/
WrapperGen/
124 lines
utils/
tools/
WrapperGen/
152 lines

Diff 312524

View Options

libc/test/utils/tools/WrapperGen/wrappergen_test.cpp

Loading...
View Options

libc/utils/tools/WrapperGen/Main.cpp

Loading...