This is an archive of the discontinued LLVM Phabricator instance.

Differential D93358

Remove erroneous trailing comma in arcconfig
ClosedPublic

Authored by GMNGeoffrey on Dec 15 2020, 4:50 PM.

Details

Reviewers
mehdi_amini
Commits
rG1198478c4208: [lld/mac] remove redundant null check
rW88febbd59f85: Remove erroneous trailing comma in arcconfig
Summary

Before this fix I get this error (that location info leaves much to be desired):

[2020-12-16 00:51:42] EXCEPTION: (PhutilJSONParserException)
Parse error on line 5 at column 22: Expected: 'STRING' -
It appears you have an extra trailing comma at
[<arcanist>/src/parser/PhutilJSONParser.php:34]

Diff Detail

Repository
rW llvm-www

Event Timeline

GMNGeoffrey requested review of this revision.Dec 15 2020, 4:50 PM
GMNGeoffrey created this revision.
Harbormaster completed remote builds in B82559: Diff 312075.Dec 15 2020, 4:50 PM
GMNGeoffrey added a reviewer: mehdi_amini.Dec 15 2020, 4:51 PM
GMNGeoffrey edited the summary of this revision. (Show Details)
mehdi_amini accepted this revision.Dec 15 2020, 5:02 PM
This revision is now accepted and ready to land.Dec 15 2020, 5:02 PM
Closed by commit rW88febbd59f85: Remove erroneous trailing comma in arcconfig (authored by mehdi_amini). · Explain WhyDec 15 2020, 5:04 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rW88febbd59f85: Remove erroneous trailing comma in arcconfig.
mehdi_amini added a comment.Dec 15 2020, 5:05 PM

(Landed separately)

• ldam666fr added a commit: rG1198478c4208: [lld/mac] remove redundant null check.Jan 10 2021, 1:11 AM

Revision Contents

PathSize
2 lines

Diff 312079

.arcconfig

{ {
"phabricator.uri" : "https://reviews.llvm.org/", "phabricator.uri" : "https://reviews.llvm.org/",
"repository.callsign" : "W", "repository.callsign" : "W",
"conduit_uri" : "https://reviews.llvm.org/", "conduit_uri" : "https://reviews.llvm.org/",
"base": "git:HEAD^", "base": "git:HEAD^"
} }