This is an archive of the discontinued LLVM Phabricator instance.

Remove trap code from disassembly.
ClosedPublic

Authored by chaoren on Apr 28 2015, 4:28 PM.

Details

Summary

NativeProcessProtocol uses ReadMemory internally for setting/checking
breakpoints but also for generic memory reads (Handle_m), this change adds a
ReadMemoryWithoutTrap for that purpose.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 24583.Apr 28 2015, 4:28 PM
chaoren retitled this revision from to Remove trap code from disassembly..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: clayborg, jingham, vharron.
chaoren added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Apr 28 2015, 4:52 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Apr 28 2015, 4:52 PM
chaoren updated this revision to Diff 24589.Apr 28 2015, 5:40 PM
chaoren edited edge metadata.

Fix some other places where addr_t is used as size.

This revision was automatically updated to reflect the committed changes.