This is an archive of the discontinued LLVM Phabricator instance.

Fix -fno-gnu-inline-asm doesn't catch file scope asm
ClosedPublic

Authored by steven_wu on Apr 28 2015, 1:31 PM.

Details

Summary

FileScopeAsm should be treated the same as funcion level inline asm.
-fno-gnu-inline-asm should trigger an error if file scope asm is used.
I missed this case from r226340. This should not affect ms-extension
because it is not allowed in the file scope.

Diff Detail

Repository
rL LLVM

Event Timeline

steven_wu updated this revision to Diff 24573.Apr 28 2015, 1:31 PM
steven_wu retitled this revision from to Fix -fno-gnu-inline-asm doesn't catch file scope asm.
steven_wu updated this object.
steven_wu edited the test plan for this revision. (Show Details)
steven_wu added reviewers: bob.wilson, rnk.
steven_wu added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Apr 28 2015, 1:35 PM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Apr 28 2015, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Thanks. Committed in r236044.