This is an archive of the discontinued LLVM Phabricator instance.

Add an unnamed pipe fail-safe to launching lldb-gdbserver.
ClosedPublic

Authored by chaoren on Apr 27 2015, 3:32 PM.

Details

Summary

Currently, launching lldb-gdbserver from platform on Android requires root for
mkfifo() and an explicit TMPDIR variable. This should remove both requirements.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 24506.Apr 27 2015, 3:32 PM
chaoren retitled this revision from to Add an unnamed pipe fail-safe to launching lldb-gdbserver..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: clayborg, tberghammer, vharron.
chaoren added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Apr 27 2015, 3:59 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Apr 27 2015, 3:59 PM
This revision was automatically updated to reflect the committed changes.
ovyalov added inline comments.
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
322 ↗(On Diff #24512)

Could we pass Pipe by reference here? Otherwise ~Pipe is called twice trying to close the same pipe descriptor more than once.