This is an archive of the discontinued LLVM Phabricator instance.

[mips] [IAS] Warn when LA is used with a 64-bit symbol.
ClosedPublic

Authored by tomatabacu on Apr 27 2015, 8:21 AM.

Diff Detail

Event Timeline

dsanders added inline comments.Apr 30 2015, 5:49 AM
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
1930–1932

I don't think this warning is correct. O32 and N32 should be able to use 'la' on a 64-bit CPU. The warning makes sense for N64 though.

tomatabacu updated this revision to Diff 25069.May 6 2015, 10:45 AM
tomatabacu retitled this revision from [mips] [IAS] Don't do 64-bit expansions for LA of symbol. to [mips] [IAS] Warn when LA is used with a 64-bit symbol..
tomatabacu updated this object.

Changed summary and title to match the actual change.
Changed to warn only for N64.
Updated test.

dsanders accepted this revision.May 13 2015, 3:22 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 13 2015, 3:22 AM
tomatabacu closed this revision.May 14 2015, 3:57 AM