Previously the CHECK directives only matched decimal digits causing it to match
'7' on x86_64 instead of the whole value.
This fixes a failure on mips-linux-gnu targets where the leading digit is 'a'.
Differential D9199
[asan] debug_mapping.cc should also pass when the leading digit is hexadecimal. dsanders on Apr 22 2015, 9:22 AM. Authored by
Details
Previously the CHECK directives only matched decimal digits causing it to match This fixes a failure on mips-linux-gnu targets where the leading digit is 'a'.
Diff Detail Event TimelineComment Actions Can you please provide an example output that doesn't match this? ср, 22 апр. 2015, 19:23, Daniel Sanders <daniel.sanders@imgtec.com>:
Comment Actions Sure. On a mips-linux-gnu target I get: 941==AddressSanitizer: failed to intercept '__isoc99_printf'941==AddressSanitizer: failed to intercept '__isoc99_sprintf'941==AddressSanitizer: failed to intercept '__isoc99_snprintf'941==AddressSanitizer: failed to intercept '__isoc99_fprintf'941==AddressSanitizer: failed to intercept '__isoc99_vprintf'941==AddressSanitizer: failed to intercept '__isoc99_vsprintf'941==AddressSanitizer: failed to intercept '__isoc99_vsnprintf'941==AddressSanitizer: failed to intercept '__isoc99_vfprintf'941==AddressSanitizer: libc interceptors initialized
MemToShadow(shadow): 0x0bff4000 0x0c29e7ff 0x0ca9e800 0x0fff3fff 941==Installed the sigaction for signal 11941==Installed the sigaction for signal 10941==T0: stack [0x7f43d000,0x7fc3d000) size 0x800000; local=0x7fc3cab8941==AddressSanitizer Init donescale: 3 The 'CHECK: SHADOW_OFFSET: [[OFFSET:[0-9]+]]' fails to match 'SHADOW_OFFSET: aaa0000'. Comment Actions SHADOW_OFFSET expression change -- LGTM
Comment Actions I don't mind only changing the SHADOW_OFFSET expression since that fixes my test failure but I have to ask: Comment Actions Nice catch, I've overlooked that code! SHADOW_SCALE is currently a constant equal to 3 and it can't be more than 8 with the current ASan design, I think? That's being said, I think the Printf line you're referring to should be changed to just use %d. Comment Actions Thanks for working on this! чт, 23 апр. 2015 г. в 16:54, Daniel Sanders <Daniel.Sanders@imgtec.com>:
|
Please leave the SCALE regexp unchanged