This is an archive of the discontinued LLVM Phabricator instance.

[ubsan] Stop cast-overflow.cpp test leaking undefined behaviour into the exit code.
ClosedPublic

Authored by dsanders on Apr 21 2015, 7:51 AM.

Details

Summary

ubsan was correctly catching the undefined behaviour but lit's shell was
failing the test anyway because the exit code was non-zero as a result of the
undefined behaviour.

This fixes the test on a mips-linux-gnu target.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 24134.Apr 21 2015, 7:51 AM
dsanders retitled this revision from to [ubsan] Stop cast-overflow.cpp test leaking undefined behaviour into the exit code..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added subscribers: slthakur, rsmith, Unknown Object (MLST).
samsonov accepted this revision.Apr 21 2015, 10:21 AM
samsonov added a reviewer: samsonov.
samsonov added a subscriber: samsonov.

LGTM

This revision is now accepted and ready to land.Apr 21 2015, 10:21 AM
dsanders closed this revision.Apr 22 2015, 9:17 AM