Page MenuHomePhabricator
Differential D91075

[clang] Fix ForStmt mustprogress handling
ClosedPublic
Actions

Authored by atmnpatel on Nov 9 2020, 6:29 AM.

Details

Reviewers
jdoerfert
aqjune
aaron.ballman
Commits
rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling
Summary

D86841 had an error where for statements with no conditional were
required to make progress. This is not true, this patch removes that
line, and adds regression tests.

Diff Detail

Event Timeline

atmnpatel created this revision.Nov 9 2020, 6:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2020, 6:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
atmnpatel requested review of this revision.Nov 9 2020, 6:29 AM
jdoerfert accepted this revision.Nov 9 2020, 6:57 AM

LGTM

This revision is now accepted and ready to land.Nov 9 2020, 6:57 AM
Harbormaster completed remote builds in B78122: Diff 303857.Nov 9 2020, 7:00 AM
This revision was landed with ongoing or failed builds.Nov 9 2020, 8:38 AM
Closed by commit rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling (authored by atmnpatel). · Explain Why
This revision was automatically updated to reflect the committed changes.
atmnpatel added a commit: rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling.

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
1 line
test/
CodeGen/
11 lines
10 lines

Diff 303890

View Options

clang/lib/CodeGen/CGStmt.cpp

Loading...
View Options

clang/test/CodeGen/attr-mustprogress-1.c

Loading...
View Options

clang/test/CodeGen/attr-mustprogress-1.cpp

Loading...