Page MenuHomePhabricator

TestMiBreak - func isn't always ??.
ClosedPublic

Authored by chaoren on Apr 16 2015, 2:16 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren retitled this revision from to TestMiBreak - func isn't always ??..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added a reviewer: ki.stfu.
chaoren added a subscriber: Unknown Object (MLST).
ki.stfu accepted this revision.Apr 16 2015, 9:43 PM
ki.stfu edited edge metadata.

Thanks a lot!

This revision is now accepted and ready to land.Apr 16 2015, 9:43 PM
ki.stfu requested changes to this revision.Apr 17 2015, 6:26 AM
ki.stfu edited edge metadata.
ki.stfu added inline comments.
test/tools/lldb-mi/breakpoint/TestMiBreak.py
34 ↗(On Diff #23881)

update this patch after r235189 and use the following:

func=\".+?\"
This revision now requires changes to proceed.Apr 17 2015, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Why not func=\".*\"?

Why not func=\".*\"?

To match the shortest string. For example, if we have the following input:
^done,bkpt={someval}
.=breakpoint-modified,bkpt={someval}

then the "\^done,bkpt=\{.*\}" will match for (see bold text):
^done,bkpt={someval}
.=breakpoint-modified,bkpt={someval
}

but the "\^done,bkpt=\{.*?\}" will match for:
^done,bkpt={someval}
.=breakpoint-modified,bkpt={someval}