This is an archive of the discontinued LLVM Phabricator instance.

Replace loop doing postorder walk with postorder iterator
ClosedPublic

Authored by dberlin on Apr 15 2015, 10:52 AM.

Diff Detail

Event Timeline

dberlin retitled this revision from to Replace loop doing postorder walk with postorder iterator.
dberlin updated this object.
dberlin edited the test plan for this revision. (Show Details)
dberlin added a reviewer: chandlerc.
dberlin added a subscriber: Unknown Object (MLST).
chandlerc accepted this revision.Apr 15 2015, 5:10 PM
chandlerc edited edge metadata.

Looks good with a tiny nit fixed below.

include/llvm/Analysis/LoopInfoImpl.h
425

Especially here, where post_order could return anything, I'd write out explicitly "for (BlockT *BB : ...)".

This revision is now accepted and ready to land.Apr 15 2015, 5:10 PM
This revision was automatically updated to reflect the committed changes.