Use llvm::sys::fs::create_directories to create new directory on Windows

[ovyalov]

Summary

Use llvm::sys::fs::create_directories to create new directory on Windows - to allow recursive creation of non-existing folders.

[zturner]

I kind of don't like the shell functions and would prefer to avoid them wherever possible. They're very heavyweight, can fail for mysterious reasons, and are all intertwined with displaying UI and all other kinds of unnecessary stuff. Plus, MSDN says this function was dropped in Vista (There's SHCreateDirectoryEx apparently, but even that function has a deprecation warning on MSDN).

LLVM has llvm::sys::fs::create_directories() in llvm/Support/FileSystem.h. Can you try that and see if it satisfies your needs?

[ovyalov]

Switched to use lvm::sys::fs::create_directories instead of SHCreateDirectory.
Please take another look.

[zturner]

Looks good

[ovyalov]

Submitted as r234610

source/Host/windows/FileSystem.cpp

 //===-- FileSystem.cpp ------------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "lldb/Host/windows/windows.h"
 
 #include <shellapi.h>
 
 #include "lldb/Host/FileSystem.h"
+#include "llvm/Support/FileSystem.h"
 
 using namespace lldb_private;
 
 FileSpec::PathSyntax
 FileSystem::GetNativePathSyntax()
 {
     return FileSpec::ePathSyntaxWindows;
 }
 
 Error
 FileSystem::MakeDirectory(const char *path, uint32_t file_permissions)
 {
     // On Win32, the mode parameter is ignored, as Windows files and directories support a
     // different permission model than POSIX.
     Error error;
-    if (!::CreateDirectory(path, NULL) && GetLastError() != ERROR_ALREADY_EXISTS)
-        error.SetError(::GetLastError(), lldb::eErrorTypeWin32);
+    const auto err_code = llvm::sys::fs::create_directories(path, true);
+    if (err_code)
+    {
+        error.SetErrorString(err_code.message().c_str());
+    }
+
     return error;
 }
 
 Error
 FileSystem::DeleteDirectory(const char *path, bool recurse)
 {
     Error error;
     if (!recurse)