Page MenuHomePhabricator

[AMDGPU] Correct hsa-diag-v3.s test
ClosedPublic

Authored by t-tye on Sat, Oct 17, 3:10 PM.

Details

Summary
  • Use file_check -LABEL markers to prevent false positives being reported due to messages from different tests causing success to be reported.
  • Add checks for all the run commands for more robust testing.
  • Add checks for the absence of errors.
  • Name and order tests more sensibly.

Diff Detail

Event Timeline

t-tye created this revision.Sat, Oct 17, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Oct 17, 3:10 PM
t-tye requested review of this revision.Sat, Oct 17, 3:10 PM
t-tye updated this revision to Diff 298917.Sun, Oct 18, 7:22 PM

Use FileCheck --check-prefixes

t-tye updated this revision to Diff 298918.Sun, Oct 18, 7:33 PM

Correct whitespace.

t-tye updated this revision to Diff 298930.Sun, Oct 18, 10:27 PM

Generalize label names.

scott.linder accepted this revision.Mon, Oct 19, 8:12 AM

LGTM, thank you!

This revision is now accepted and ready to land.Mon, Oct 19, 8:12 AM
This revision was landed with ongoing or failed builds.Mon, Oct 19, 10:09 AM
This revision was automatically updated to reflect the committed changes.