This is an archive of the discontinued LLVM Phabricator instance.

Link libm in the complex-5.c testcase
ClosedPublic

Authored by arichardson on Oct 17 2020, 4:42 AM.

Download Raw Diff

Details

Reviewers

lenary
dim

Commits

rTc84b15fc6f84: Link libm in the complex-5.c testcase

Summary

This appears to be needed on FreeBSD:

ld.lld: error: undefined symbol: scalbnf

referenced by divsc3.c:26 (/Users/alex/cheri/cheribsd/contrib/llvm-project/compiler-rt/lib/builtins/divsc3.c:26)
divsc3.o:(__divsc3) in archive /Users/alex/cheri/output/sdk/sysroot-riscv64/usr/lib64/libgcc.a
referenced by divsc3.c:27 (/Users/alex/cheri/cheribsd/contrib/llvm-project/compiler-rt/lib/builtins/divsc3.c:27)
divsc3.o:(__divsc3) in archive /Users/alex/cheri/output/sdk/sysroot-riscv64/usr/lib64/libgcc.a
referenced by divsc3.c:31 (/Users/alex/cheri/cheribsd/contrib/llvm-project/compiler-rt/lib/builtins/divsc3.c:31)
divsc3.o:(__divsc3) in archive /Users/alex/cheri/output/sdk/sysroot-riscv64/usr/lib64/libgcc.a
referenced 1 more times

Diff Detail

Repository: rT test-suite

Event Timeline

arichardson created this revision.Oct 17 2020, 4:42 AM

Herald added subscribers: s.egerton, PkmX, simoncook and 3 others. · View Herald TranscriptOct 17 2020, 4:42 AM

arichardson requested review of this revision.Oct 17 2020, 4:42 AM

Harbormaster completed remote builds in B75421: Diff 298822.Oct 17 2020, 4:42 AM

I haven't had time to run with this patch, but this seems like the right fix to me.

Will commit this next week unless there are any objections.

lenary accepted this revision.Jan 14 2021, 9:46 AM

This revision is now accepted and ready to land.Jan 14 2021, 9:46 AM

arichardson changed the repository for this revision from rOLDT svn-test-suite to rT test-suite.Jan 20 2021, 7:53 AM

Closed by commit rTc84b15fc6f84: Link libm in the complex-5.c testcase (authored by arichardson). · Explain WhyJan 20 2021, 7:53 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rTc84b15fc6f84: Link libm in the complex-5.c testcase.

Revision Contents

Path

Size

SingleSource/

Regression/

gcc-c-torture/

execute/

CMakeLists.txt

1 line

Diff 317880

SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt

Show First 20 Lines • Show All 184 Lines • ▼ Show 20 Lines	file(GLOB TestRequiresWNoReturnType CONFIGURE_DEPENDS
920501-3.c		920501-3.c
920728-1.c		920728-1.c
)		)

# Tests that require libm (-lm ldflag)		# Tests that require libm (-lm ldflag)
file(GLOB TestRequiresLibM CONFIGURE_DEPENDS		file(GLOB TestRequiresLibM CONFIGURE_DEPENDS
980709-1.c		980709-1.c
float-floor.c		float-floor.c
		complex-5.c # -lm needed on FreeBSD
)		)

# Tests that require newnlib Nano IO (--undefined=_printf_float ldflag)		# Tests that require newnlib Nano IO (--undefined=_printf_float ldflag)
file(GLOB TestRequiresNanoIO CONFIGURE_DEPENDS		file(GLOB TestRequiresNanoIO CONFIGURE_DEPENDS
920501-8.c		920501-8.c
930513-1.c		930513-1.c
)		)

▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines