The patch is generated using clang-tidy misc-use-override check.
This command was used:
tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix
Paths
| Differential D8926
Use 'override/final' instead of 'virtual' for overridden methods ClosedPublic Authored by alexfh on Apr 9 2015, 10:30 AM.
Details Summary The patch is generated using clang-tidy misc-use-override check. This command was used: tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix
Diff Detail Event TimelineComment Actions Recreated the patch using: tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix -format Fewer formatting-only changes. dblaikie edited edge metadata. Comment ActionsLooks good to me. Looks like we missed a bunch of 'override' in Clang in general, great to put it in and remove the redundant virtual at the same time.
This revision is now accepted and ready to land.Apr 10 2015, 4:40 PM
Revision Contents
Diff 23515 examples/PrintFunctionNames/PrintFunctionNames.cpp
include/clang/AST/VTableBuilder.h
include/clang/ASTMatchers/ASTMatchersInternal.h
include/clang/ASTMatchers/Dynamic/Parser.h
include/clang/ASTMatchers/Dynamic/VariantValue.h
include/clang/Analysis/Analyses/Dominators.h
include/clang/Analysis/Analyses/LiveVariables.h
include/clang/Analysis/AnalysisContext.h
include/clang/Basic/Diagnostic.h
include/clang/CodeGen/CodeGenAction.h
include/clang/Driver/Job.h
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/CompilerInstance.h
include/clang/Frontend/DiagnosticRenderer.h
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/MultiplexConsumer.h
include/clang/Frontend/TextDiagnostic.h
include/clang/Frontend/TextDiagnosticPrinter.h
include/clang/Frontend/VerifyDiagnosticConsumer.h
include/clang/Lex/PTHLexer.h
include/clang/Lex/PTHManager.h
include/clang/Lex/Pragma.h
include/clang/Parse/Parser.h
include/clang/Rewrite/Frontend/FixItRewriter.h
include/clang/Rewrite/Frontend/FrontendActions.h
include/clang/Sema/ExternalSemaSource.h
include/clang/Sema/MultiplexExternalSemaSource.h
include/clang/Sema/ScopeInfo.h
include/clang/Serialization/ASTReader.h
include/clang/Serialization/ASTWriter.h
include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
include/clang/Tooling/Tooling.h
lib/ARCMigrate/ARCMT.cpp
lib/ARCMigrate/ObjCMT.cpp
lib/ASTMatchers/ASTMatchFinder.cpp
lib/ASTMatchers/Dynamic/Marshallers.h
lib/Analysis/CFG.cpp
lib/Analysis/UninitializedValues.cpp
lib/Basic/Targets.cpp
lib/Basic/VirtualFileSystem.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/ModuleBuilder.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/ToolChains.h
lib/Format/UnwrappedLineParser.cpp
lib/Frontend/CacheTokens.cpp
lib/Frontend/ChainedIncludesSource.cpp
lib/Frontend/FrontendAction.cpp
lib/Frontend/FrontendActions.cpp
lib/Frontend/HeaderIncludeGen.cpp
lib/Frontend/Rewrite/RewriteModernObjC.cpp
lib/Frontend/Rewrite/RewriteObjC.cpp
lib/Frontend/SerializedDiagnosticPrinter.cpp
lib/Frontend/VerifyDiagnosticConsumer.cpp
lib/Sema/AnalysisBasedWarnings.cpp
lib/Sema/SemaExprCXX.cpp
lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.h
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
lib/StaticAnalyzer/Frontend/ModelInjector.h
lib/Tooling/CompilationDatabase.cpp
tools/libclang/CIndexCodeCompletion.cpp
tools/libclang/CIndexDiagnostic.h
tools/libclang/CIndexDiagnostic.cpp
tools/libclang/CXLoadedDiagnostic.h
tools/libclang/CXLoadedDiagnostic.cpp
unittests/AST/DeclPrinterTest.cpp
unittests/AST/ExternalASTSourceTest.cpp
unittests/AST/MatchVerifier.h
unittests/AST/NamedDeclPrinterTest.cpp
unittests/AST/SourceLocationTest.cpp
unittests/AST/StmtPrinterTest.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
unittests/Basic/SourceManagerTest.cpp
unittests/Basic/VirtualFileSystemTest.cpp
unittests/Frontend/FrontendActionTest.cpp
unittests/Lex/PPCallbacksTest.cpp
unittests/Sema/ExternalSemaSourceTest.cpp
unittests/Tooling/CommentHandlerTest.cpp
unittests/Tooling/CompilationDatabaseTest.cpp
unittests/Tooling/RefactoringTest.cpp
unittests/Tooling/TestVisitor.h
unittests/Tooling/ToolingTest.cpp
unittests/libclang/LibclangTest.cpp
utils/TableGen/NeonEmitter.cpp
|
Do we have a clang-tidy warning for explicitly writing default definitions of functions? Would love to just not have this sort of code written at all.