No changes in the existing runtime and therefore no calls to the new functions.
Details
Diff Detail
Event Timeline
runtime/CMakeLists.txt | ||
---|---|---|
612 | Ok, will update this with the next revision |
I just noticed that there is a CMakeLists.txt in runtime/src/ as well. Is it deprecated?
I can safely remove the file and the build with CMake is still working...
This is probably a relict of the first CMake build system that can still be used with runtime/CMakeLists.txt.old (btw: this gives me an error and doesn't work at all)
Back to OMPT:
Do you want me to post updated revisions? Till now we have only included your feedback as marked in the other comments...
runtime/src/ompt-internal.h | ||
---|---|---|
8 | The Technical Report expects the version number as unsigned int... page 19,
| |
runtime/src/ompt-specific.c | ||
33 | We have tested the change and everything works as expected (only looking at the macro, there shouldn't be any difference for Unix systems at all: It evaluates to __sync_fetch_and_add) |
runtime/src/ompt-specific.c | ||
---|---|---|
33 | Yes, for Unix systems KMP_TEST_THEN_INC* macro evaluates to sync_fetch_and_add but not for Windows. As I understand the OMPT code should work on Windows as well but with sync_fetch_and_add it couldn't be even compiled. |
runtime/src/ompt-specific.c | ||
---|---|---|
33 | Sorry, not clear from my side: We have changed it to KMP_TEST_THEN_INC64 and didn't see any problems. |
You can remove this if(${OMPT_SUPPORT}) conditional. Because it is similar to a Makefile recipe, it is only called if the ompt.h file is part of the exported files.