Page MenuHomePhabricator

[Inliner][NPM] Fix various tests under NPM
ClosedPublic

Authored by aeubanks on Oct 8 2020, 8:35 PM.

Details

Summary

alloca-dbgdeclare-merge.ll:
alloca-merge-align.ll:
array_merge.ll:
NPM inliner does not merge allocas

delete-call.ll:
NPM inliner does not delete readonly calls

externally_available.ll:
NPM inliner does not delete available_externally functions

inline-cold-callee.ll:
inline-hot-callee.ll:
inline-hot-callee.ll has a comment saying it only applies to legacy PM,
I assume same for inline-cold-callee.ll

devirtualize-2.ll:
inline-hot-callsite:
monster_scc.ll:
pr22285.ll:
already has legacy and new PM RUN lines

inline-cold.ll:
profile-summary required to see callee as cold

prof-update-sample.ll:
profile-summary required to update branch_weights

Diff Detail

Event Timeline

aeubanks created this revision.Oct 8 2020, 8:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2020, 8:35 PM
aeubanks requested review of this revision.Oct 8 2020, 8:35 PM

Are the new PM inliner issues being looked into too?

davidxl accepted this revision.Oct 9 2020, 9:05 AM

lgtm

This revision is now accepted and ready to land.Oct 9 2020, 9:05 AM

There are other failing tests that look like real issues that I will look into. These are just a first pass over the failing tests that were more obvious to handle.
I read that the NPM inliner isn't supposed to handle so many weird cases like merging allocas, deleting readonly calls, etc, so those tests are pinned to the legacy inliner.

This revision was automatically updated to reflect the committed changes.