Page MenuHomePhabricator

[llvm-libtool-darwin] Add support for LLVM bitcode files
ClosedPublic

Authored by parras on Oct 2 2020, 1:43 AM.

Details

Summary

This diff adds support for LLVM bitcode objects, archives and universal binaries, in llvm-libtool-darwin.
This was suggested in https://reviews.llvm.org/D85740#2234221

Diff Detail

Event Timeline

parras created this revision.Oct 2 2020, 1:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 1:43 AM
Herald added a subscriber: zzheng. · View Herald Transcript
parras requested review of this revision.Oct 2 2020, 1:43 AM

sorry about the delay, I'll try to review this diff this week / early next week

sorry about the delay, I'll try to review this diff this week / early next week

@alexshap Did you have a chance to take a look?

alexshap accepted this revision.Oct 23 2020, 6:18 PM

Looks good!
I'd wait for @smeenai to take a look as well.

This revision is now accepted and ready to land.Oct 23 2020, 6:18 PM
smeenai accepted this revision.Oct 23 2020, 9:07 PM

LGTM, sorry for the slow review.

Thanks @alexshap and @smeenai for accepting the revision ! However I don't have commit access, so I won't be able to merge it myself.

@parras - thanks for the patch! According to https://llvm.org/docs/DeveloperPolicy.html#commit-messages to correctly specify the author of the changes we need name + e-mail

@parras - thanks for the patch! According to https://llvm.org/docs/DeveloperPolicy.html#commit-messages to correctly specify the author of the changes we need name + e-mail

Author: Paul-Antoine Arras <paarras@quarkslab.com>

Thank you!

This revision was automatically updated to reflect the committed changes.