This is an archive of the discontinued LLVM Phabricator instance.

Differential D8806

Fix debug register offset on FreeBSD.
AbandonedPublic

Authored by chaoren on Apr 2 2015, 11:32 AM.

Details

Reviewers
emaste
Summary

As per emaste's comment here: http://reviews.llvm.org/D8685.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 23172.Apr 2 2015, 11:32 AM
chaoren retitled this revision from to Fix debug register offset on FreeBSD.
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added a reviewer: emaste.
chaoren added a subscriber: Unknown Object (MLST).
Herald added a subscriber: emaste. · View Herald TranscriptApr 2 2015, 11:32 AM
chaoren retitled this revision from Fix debug register offset on FreeBSD to Fix debug register offset on FreeBSD..Apr 2 2015, 11:32 AM
chaoren abandoned this revision.Apr 3 2015, 1:56 PM

Already fixed by rL234048.

Revision Contents

PathSize
source/
Plugins/
Process/
Utility/
17 lines
4 lines
4 lines

Diff 23172

source/Plugins/Process/Utility/RegisterContextFreeBSD_x86_64.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Linestypedef struct _GPR
uint64_t rip; uint64_t rip;
uint64_t cs; uint64_t cs;
uint64_t rflags; uint64_t rflags;
uint64_t rsp; uint64_t rsp;
uint64_t ss; uint64_t ss;
} GPR; } GPR;
struct DBG { struct DBG {
uint64_t dr[16]; /* debug registers */ uint64_t dr[16]; /* debug registers */
/* Index 0-3: debug address registers */ /* Index 0-3: debug address registers */
/* Index 4-5: reserved */ /* Index 4-5: reserved */
/* Index 6: debug status */ /* Index 6: debug status */
/* Index 7: debug control */ /* Index 7: debug control */
/* Index 8-15: reserved */ /* Index 8-15: reserved */
}; };
struct UserArea struct UserArea
{ {
GPR gpr; GPR gpr;
FPR fpr; FPR fpr;
DBG dbg;
}; };
// Debug register implementation on FreeBSD is different from Linux.
#define DR_OFFSET(reg_index) \
(LLVM_EXTENSION offsetof(DBG, dr[reg_index]))
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------
// Include RegisterInfos_x86_64 to declare our g_register_infos_x86_64 structure. // Include RegisterInfos_x86_64 to declare our g_register_infos_x86_64 structure.
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------
#define DECLARE_REGISTER_INFOS_X86_64_STRUCT #define DECLARE_REGISTER_INFOS_X86_64_STRUCT
#include "RegisterInfos_x86_64.h" #include "RegisterInfos_x86_64.h"
#undef DECLARE_REGISTER_INFOS_X86_64_STRUCT #undef DECLARE_REGISTER_INFOS_X86_64_STRUCT
static std::vector<lldb_private::RegisterInfo>& static std::vector<lldb_private::RegisterInfo>&
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines

source/Plugins/Process/Utility/RegisterContextLinux_x86_64.cpp

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Linesstruct UserArea
FXSAVE* fpstate; // Location of FPR's. FXSAVE* fpstate; // Location of FPR's.
uint64_t magic; // Identifier for core dumps. uint64_t magic; // Identifier for core dumps.
char u_comm[32]; // Command causing core dump. char u_comm[32]; // Command causing core dump.
DBG dbg; // Debug registers. DBG dbg; // Debug registers.
uint64_t error_code; // CPU error code. uint64_t error_code; // CPU error code.
uint64_t fault_address; // Control register CR3. uint64_t fault_address; // Control register CR3.
}; };
#define DR_OFFSET(reg_index) \
(LLVM_EXTENSION offsetof(UserArea, dbg) + \
LLVM_EXTENSION offsetof(DBG, dr[reg_index]))
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------
// Include RegisterInfos_x86_64 to declare our g_register_infos_x86_64 structure. // Include RegisterInfos_x86_64 to declare our g_register_infos_x86_64 structure.
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------
#define DECLARE_REGISTER_INFOS_X86_64_STRUCT #define DECLARE_REGISTER_INFOS_X86_64_STRUCT
#include "RegisterInfos_x86_64.h" #include "RegisterInfos_x86_64.h"
#undef DECLARE_REGISTER_INFOS_X86_64_STRUCT #undef DECLARE_REGISTER_INFOS_X86_64_STRUCT
static std::vector<lldb_private::RegisterInfo>& static std::vector<lldb_private::RegisterInfo>&
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

source/Plugins/Process/Utility/RegisterInfos_x86_64.h

Show All 21 Lines
// Computes the offset of the YMM register assembled from register halves. // Computes the offset of the YMM register assembled from register halves.
#define YMM_OFFSET(reg_index) \ #define YMM_OFFSET(reg_index) \
(LLVM_EXTENSION offsetof(UserArea, fpr) + \ (LLVM_EXTENSION offsetof(UserArea, fpr) + \
LLVM_EXTENSION offsetof(FPR, xstate) + \ LLVM_EXTENSION offsetof(FPR, xstate) + \
LLVM_EXTENSION offsetof(XSAVE, ymmh[reg_index]) + \ LLVM_EXTENSION offsetof(XSAVE, ymmh[reg_index]) + \
(32 * reg_index)) (32 * reg_index))
#define DR_OFFSET(reg_index) \
(LLVM_EXTENSION offsetof(UserArea, dbg) + \
LLVM_EXTENSION offsetof(DBG, dr[reg_index]))
#ifdef DECLARE_REGISTER_INFOS_X86_64_STRUCT #ifdef DECLARE_REGISTER_INFOS_X86_64_STRUCT
// Number of bytes needed to represent a FPR. // Number of bytes needed to represent a FPR.
#define FPR_SIZE(reg) sizeof(((FXSAVE*)NULL)->reg) #define FPR_SIZE(reg) sizeof(((FXSAVE*)NULL)->reg)
// Number of bytes needed to represent the i'th FP register. // Number of bytes needed to represent the i'th FP register.
#define FP_SIZE sizeof(((MMSReg*)NULL)->bytes) #define FP_SIZE sizeof(((MMSReg*)NULL)->bytes)
▲ Show 20 Lines • Show All 380 Lines • Show Last 20 Lines