This is an archive of the discontinued LLVM Phabricator instance.

Differential D88058

[UnifyLoopExits] Pin tests with -unify-loop-exits to legacy PM
ClosedPublic

Authored by aeubanks on Sep 21 2020, 4:53 PM.

Details

Reviewers
ychen
asbirlea
Commits
rG89df0fda1767: [UnifyLoopExits] Pin tests with -unify-loop-exits to legacy PM
Summary

The pass is not used in tree, so no reason to port it.

Diff Detail

Event Timeline

aeubanks created this revision.Sep 21 2020, 4:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2020, 4:53 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks requested review of this revision.Sep 21 2020, 4:53 PM
aeubanks mentioned this in D87734: [UnifyLoopExits][NewPM] Port unify-loop-exits to NPM.Sep 21 2020, 4:54 PM
asbirlea accepted this revision.Sep 21 2020, 5:04 PM
This revision is now accepted and ready to land.Sep 21 2020, 5:04 PM
Harbormaster completed remote builds in B72448: Diff 293293.Sep 21 2020, 5:42 PM
Closed by commit rG89df0fda1767: [UnifyLoopExits] Pin tests with -unify-loop-exits to legacy PM (authored by aeubanks). · Explain WhySep 21 2020, 6:09 PM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG89df0fda1767: [UnifyLoopExits] Pin tests with -unify-loop-exits to legacy PM.

Revision Contents

PathSize
llvm/
test/
Transforms/
StructurizeCFG/
workarounds/
2 lines
2 lines
UnifyLoopExits/
2 lines
2 lines
2 lines
2 lines

Diff 293308

llvm/test/Transforms/StructurizeCFG/workarounds/needs-fr-ule.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -fix-irreducible -unify-loop-exits -structurizecfg -S | FileCheck %s ; RUN: opt < %s -fix-irreducible -unify-loop-exits -structurizecfg -enable-new-pm=0 -S | FileCheck %s
define void @irreducible_mountain_bug(i1 %Pred0, i1 %Pred1, i1 %Pred2, i1 %Pred3, i1 %Pred4, i1 %Pred5, i1 %Pred6, i1 %Pred7, i1 %Pred8, i1 %Pred9, i1 %Pred10, i1 %Pred11, i1 %Pred12, i1 %Pred13) { define void @irreducible_mountain_bug(i1 %Pred0, i1 %Pred1, i1 %Pred2, i1 %Pred3, i1 %Pred4, i1 %Pred5, i1 %Pred6, i1 %Pred7, i1 %Pred8, i1 %Pred9, i1 %Pred10, i1 %Pred11, i1 %Pred12, i1 %Pred13) {
; CHECK-LABEL: @irreducible_mountain_bug( ; CHECK-LABEL: @irreducible_mountain_bug(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[PRED0_INV:%.*]] = xor i1 [[PRED0:%.*]], true ; CHECK-NEXT: [[PRED0_INV:%.*]] = xor i1 [[PRED0:%.*]], true
; CHECK-NEXT: [[PRED1_INV:%.*]] = xor i1 [[PRED1:%.*]], true ; CHECK-NEXT: [[PRED1_INV:%.*]] = xor i1 [[PRED1:%.*]], true
; CHECK-NEXT: [[PRED2_INV:%.*]] = xor i1 [[PRED2:%.*]], true ; CHECK-NEXT: [[PRED2_INV:%.*]] = xor i1 [[PRED2:%.*]], true
; CHECK-NEXT: [[PRED3_INV:%.*]] = xor i1 [[PRED3:%.*]], true ; CHECK-NEXT: [[PRED3_INV:%.*]] = xor i1 [[PRED3:%.*]], true
; CHECK-NEXT: [[PRED5_INV:%.*]] = xor i1 [[PRED5:%.*]], true ; CHECK-NEXT: [[PRED5_INV:%.*]] = xor i1 [[PRED5:%.*]], true
▲ Show 20 Lines • Show All 176 Lines • Show Last 20 Lines

llvm/test/Transforms/StructurizeCFG/workarounds/needs-unified-loop-exits.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -unify-loop-exits -structurizecfg -S | FileCheck %s ; RUN: opt < %s -unify-loop-exits -structurizecfg -enable-new-pm=0 -S | FileCheck %s
; The structurizer uses an RPO traversal over a region, along with a ; The structurizer uses an RPO traversal over a region, along with a
; manual hack that is meant to sort ensure that blocks within a loop ; manual hack that is meant to sort ensure that blocks within a loop
; are all visited before visiting blocks outside the loop. But this ; are all visited before visiting blocks outside the loop. But this
; does not always work as expected. For example the results are ; does not always work as expected. For example the results are
; incorrect when multiple nested loops are involved. ; incorrect when multiple nested loops are involved.
; The workaround for this is to unify loop exits. Each loop now ; The workaround for this is to unify loop exits. Each loop now
▲ Show 20 Lines • Show All 163 Lines • Show Last 20 Lines

llvm/test/Transforms/UnifyLoopExits/basic.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -unify-loop-exits -S | FileCheck %s ; RUN: opt < %s -unify-loop-exits -enable-new-pm=0 -S | FileCheck %s
define void @loop_1(i1 %PredEntry, i1 %PredB, i1 %PredC, i1 %PredD) { define void @loop_1(i1 %PredEntry, i1 %PredB, i1 %PredC, i1 %PredD) {
; CHECK-LABEL: @loop_1( ; CHECK-LABEL: @loop_1(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br i1 [[PREDENTRY:%.*]], label [[A:%.*]], label [[G:%.*]] ; CHECK-NEXT: br i1 [[PREDENTRY:%.*]], label [[A:%.*]], label [[G:%.*]]
; CHECK: A: ; CHECK: A:
; CHECK-NEXT: br label [[B:%.*]] ; CHECK-NEXT: br label [[B:%.*]]
; CHECK: B: ; CHECK: B:
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines

llvm/test/Transforms/UnifyLoopExits/nested.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -unify-loop-exits -S | FileCheck %s ; RUN: opt < %s -unify-loop-exits -enable-new-pm=0 -S | FileCheck %s
define void @nested(i1 %PredB3, i1 %PredB4, i1 %PredA4, i1 %PredA3, i32 %X, i32 %Y, i32 %Z) { define void @nested(i1 %PredB3, i1 %PredB4, i1 %PredA4, i1 %PredA3, i32 %X, i32 %Y, i32 %Z) {
; CHECK-LABEL: @nested( ; CHECK-LABEL: @nested(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br label [[A1:%.*]] ; CHECK-NEXT: br label [[A1:%.*]]
; CHECK: A1: ; CHECK: A1:
; CHECK-NEXT: br label [[B1:%.*]] ; CHECK-NEXT: br label [[B1:%.*]]
; CHECK: B1: ; CHECK: B1:
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

llvm/test/Transforms/UnifyLoopExits/restore-ssa.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -unify-loop-exits -S | FileCheck %s ; RUN: opt < %s -unify-loop-exits -enable-new-pm=0 -S | FileCheck %s
; Loop consists of A and B: ; Loop consists of A and B:
; - A is the header ; - A is the header
; - A and B are exiting blocks ; - A and B are exiting blocks
; - C and return are exit blocks. ; - C and return are exit blocks.
; Pattern: Value (%mytmp42) defined in exiting block (A) and used in ; Pattern: Value (%mytmp42) defined in exiting block (A) and used in
; exit block (return). ; exit block (return).
; The relevant code uses DT::dominates(Value, ; The relevant code uses DT::dominates(Value,
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines

llvm/test/Transforms/UnifyLoopExits/switch.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -unify-loop-exits -S | FileCheck %s ; RUN: opt < %s -unify-loop-exits -enable-new-pm=0 -S | FileCheck %s
define void @loop_1(i32 %Value, i1 %PredEntry, i1 %PredD) { define void @loop_1(i32 %Value, i1 %PredEntry, i1 %PredD) {
; CHECK-LABEL: @loop_1( ; CHECK-LABEL: @loop_1(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br i1 [[PREDENTRY:%.*]], label [[A:%.*]], label [[G:%.*]] ; CHECK-NEXT: br i1 [[PREDENTRY:%.*]], label [[A:%.*]], label [[G:%.*]]
; CHECK: A: ; CHECK: A:
; CHECK-NEXT: br label [[B:%.*]] ; CHECK-NEXT: br label [[B:%.*]]
; CHECK: B: ; CHECK: B:
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines