This is an archive of the discontinued LLVM Phabricator instance.

Move `checkInterfaceFunction` to ModuleUtils
ClosedPublic

Authored by ismailp on Apr 1 2015, 9:37 AM.

Details

Summary

Instead of making a local copy of checkInterfaceFunction for each
sanitizer, move the function in a common place.

Diff Detail

Event Timeline

ismailp updated this revision to Diff 23066.Apr 1 2015, 9:37 AM
ismailp retitled this revision from to Move `checkInterfaceFunction` to ModuleUtils.
ismailp updated this object.
ismailp edited the test plan for this revision. (Show Details)
ismailp added reviewers: kcc, samsonov.
ismailp added a subscriber: Unknown Object (MLST).
samsonov added inline comments.Apr 1 2015, 2:02 PM
include/llvm/Transforms/Utils/ModuleUtils.h
45

You should either mention "Sanitizer" in function name, or remove it from comment and dumped error message.

ismailp updated this revision to Diff 23095.Apr 1 2015, 3:59 PM

Renamed checkInterfaceFunction to checkSanitizerInterfaceFunction.

samsonov accepted this revision.Apr 5 2015, 11:58 PM
samsonov edited edge metadata.

LGTM. Sorry, I will only be able to look at your other patches later next week (Wed-Thu).

This revision is now accepted and ready to land.Apr 5 2015, 11:58 PM
This revision was automatically updated to reflect the committed changes.

Thanks for your time!