This is an archive of the discontinued LLVM Phabricator instance.

TestConvenienceVariables - fixed a Linux problem
ClosedPublic

Authored by vharron on Mar 27 2015, 3:16 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

vharron updated this revision to Diff 22831.Mar 27 2015, 3:16 PM
vharron retitled this revision from to TestConvenienceVariables - fixed a Linux problem.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added reviewers: clayborg, sivachandra.
vharron added a subscriber: Unknown Object (MLST).
vharron updated this revision to Diff 22832.Mar 27 2015, 3:38 PM

Added comment

sivachandra accepted this revision.Mar 27 2015, 3:46 PM
sivachandra edited edge metadata.

LGTM.
One nit which you can choose to ignore.

test/functionalities/embedded_interpreter/TestConvenienceVariables.py
84 ↗(On Diff #22832)

Nit: I don't like the readability of this line. May be:

patterns=['thread #1: tid = (0x[0-9a-f]+|[0-9]+), 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ ' +
          'at main\.c:' + str(self.line) + ',' +
          '(name|queue) = \'.+\', stop reason = breakpoint 1\.1']
This revision is now accepted and ready to land.Mar 27 2015, 3:46 PM
This revision was automatically updated to reflect the committed changes.
clayborg edited edge metadata.Apr 15 2015, 11:12 AM

Looks good.