This is an archive of the discontinued LLVM Phabricator instance.

TestPrintStackTraces - made XFAIL more precise
ClosedPublic

Authored by vharron on Mar 27 2015, 3:13 PM.

Details

Summary

Works with x86_64 inferior, fails w/i386 inferior - updated test to reflect

Diff Detail

Event Timeline

vharron updated this revision to Diff 22829.Mar 27 2015, 3:13 PM
vharron retitled this revision from to TestPrintStackTraces - made XFAIL more precise.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added reviewers: clayborg, sivachandra.
vharron added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.Mar 27 2015, 3:52 PM
sivachandra edited edge metadata.
sivachandra added inline comments.
test/python_api/lldbutil/process/TestPrintStackTraces.py
34

The test is already marked xfail for i386 and linux. Why have this?

This revision is now accepted and ready to land.Mar 27 2015, 3:52 PM

Hi Greg,

Do you want us to wait for review from you on changes that are fairly Linux specific?

test/python_api/lldbutil/process/TestPrintStackTraces.py
34

It was marked as expectedFailureLinux but seems to be passing on x86_64.

clayborg accepted this revision.Mar 31 2015, 9:56 AM
clayborg edited edge metadata.
vharron closed this revision.Mar 31 2015, 10:48 AM

Committed revision 233717.