TestPrintStackTraces - made XFAIL more precise

[vharron]

Summary

Works with x86_64 inferior, fails w/i386 inferior - updated test to reflect

[sivachandra]

test/python_api/lldbutil/process/TestPrintStackTraces.py

34

The test is already marked xfail for i386 and linux. Why have this?

[vharron]

Hi Greg,

Do you want us to wait for review from you on changes that are fairly Linux specific?

test/python_api/lldbutil/process/TestPrintStackTraces.py

34

It was marked as expectedFailureLinux but seems to be passing on x86_64.

[vharron]

Committed revision 233717.

test/python_api/lldbutil/process/TestPrintStackTraces.py

class ThreadsStackTracesTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
         # Find the line number to break inside main().
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
-    @expectedFailureLinux # llvm.org/pr15415 -- partial stack trace in thread 1 (while stopped inside a read() call)
+    # llvm.org/pr23043 - leaving the next two lines in so it's easy to find this 
+    # test will appear when searching for expectedFailure(Linux|i386)
+    #@expectedFailureLinux
+    #@expectedFailurei386
     @python_api_test
     def test_stack_traces(self):
         """Test SBprocess and SBThread APIs with printing of the stack traces."""
         self.buildDefault()
         self.break_and_print_stacktraces()
 
     def break_and_print_stacktraces(self):
         """Break at main.cpp:68 and do a threads dump"""
+        if self.getArchitecture() in ['i386'] and "linux" in sys.platform:
+            self.skipTest("Skipping because this test is known to fail on i386 Linux")
+
         exe = os.path.join(os.getcwd(), "a.out")
 
         target = self.dbg.CreateTarget(exe)
         self.assertTrue(target, VALID_TARGET)
 
         breakpoint = target.BreakpointCreateByLocation("main.cpp", self.line)
         self.assertTrue(breakpoint, VALID_BREAKPOINT)