This is an archive of the discontinued LLVM Phabricator instance.

Differential D8598

Fix coverage-ld.c on systems with an Android linker in $PATH
ClosedPublic

Authored by • ehsan on Mar 24 2015, 6:04 PM.

Details

Reviewers
samsonov
Commits
rGa2956ff40517: Fix coverage-ld.c on systems with an Android linker in $PATH
rC233211: Fix coverage-ld.c on systems with an Android linker in $PATH
rL233211: Fix coverage-ld.c on systems with an Android linker in $PATH
Summary

On my system, clang tries to invoke /path/to/arm-linux-androideabi-ld
as the linker for Android, and the regex inside the test file considers
this as unacceptable.

Diff Detail

Repository
rL LLVM

Event Timeline

• ehsan updated this revision to Diff 22623.Mar 24 2015, 6:04 PM
• ehsan retitled this revision from to Fix coverage-ld.c on systems with an Android linker in $PATH.
• ehsan updated this object.
• ehsan edited the test plan for this revision. (Show Details)
• ehsan added a reviewer: samsonov.
• ehsan added a subscriber: Unknown Object (MLST).
Herald added subscribers: aemerson, tberghammer. · View Herald TranscriptMar 24 2015, 6:04 PM
samsonov accepted this revision.Mar 25 2015, 12:07 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 25 2015, 12:07 PM
Closed by commit rL233211: Fix coverage-ld.c on systems with an Android linker in $PATH (authored by • ehsan). · Explain WhyMar 25 2015, 1:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
2 lines

Diff 22671

cfe/trunk/test/Driver/coverage-ld.c

Show All 27 Lines
// CHECK-FREEBSD-X86-64: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}freebsd{{/|\\\\}}libclang_rt.profile-x86_64.a" // CHECK-FREEBSD-X86-64: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}freebsd{{/|\\\\}}libclang_rt.profile-x86_64.a"
// //
// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
// RUN: -target arm-linux-androideabi --coverage \ // RUN: -target arm-linux-androideabi --coverage \
// RUN: -resource-dir=%S/Inputs/resource_dir \ // RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: --sysroot=%S/Inputs/basic_android_tree/sysroot \ // RUN: --sysroot=%S/Inputs/basic_android_tree/sysroot \
// RUN: | FileCheck --check-prefix=CHECK-ANDROID-ARM %s // RUN: | FileCheck --check-prefix=CHECK-ANDROID-ARM %s
// //
// CHECK-ANDROID-ARM: "{{(.*[^-.0-9A-Z_a-z])?}}ld{{(.exe)?}}" // CHECK-ANDROID-ARM: "{{(.*[^.0-9A-Z_a-z])?}}ld{{(.exe)?}}"
// CHECK-ANDROID-ARM: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}linux{{/|\\\\}}libclang_rt.profile-arm-android.a" // CHECK-ANDROID-ARM: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}linux{{/|\\\\}}libclang_rt.profile-arm-android.a"