This is an archive of the discontinued LLVM Phabricator instance.

Fix sancov.py to once again support big endian
ClosedPublic

Authored by seurer on Mar 24 2015, 3:45 PM.

Details

Summary

Some recent changes to sancov.py broke ASAN for big endian. This fixes it.

Diff Detail

Event Timeline

seurer updated this revision to Diff 22610.Mar 24 2015, 3:45 PM
seurer retitled this revision from to Fix sancov.py to once again support big endian.
seurer updated this object.
seurer edited the test plan for this revision. (Show Details)
seurer added reviewers: wschmidt, kbarton, kcc, nemanjai.
seurer added a subscriber: Unknown Object (MLST).
kcc accepted this revision.Mar 24 2015, 5:35 PM
kcc edited edge metadata.

LGTM

Wow, I did not realize this is being tested on big-endian.
Sorry for the breakage. (OTOH, I now know that this is indeed being tested on big-endian)

projects/compiler-rt/lib/sanitizer_common/scripts/sancov.py
46

maybe use

idx = 1 if sys.byteorder == 'little' else 0

or at least add spaces around =

This revision is now accepted and ready to land.Mar 24 2015, 5:35 PM
seurer closed this revision.Mar 25 2015, 7:59 AM

Committed revision 233189.