This is an archive of the discontinued LLVM Phabricator instance.

CMake: enable installing utils
ClosedPublic

Authored by mtrofin on Mar 24 2015, 1:02 PM.

Details

Summary

Added a new boolean CMake flag, LLVM_INSTALL_UTILS. When set,
the 'install' target will include in the bin directory the
utils binaries - e.g. FileCheck. This mirrors the autoconfig
behavior.

Diff Detail

Event Timeline

mtrofin updated this revision to Diff 22593.Mar 24 2015, 1:02 PM
mtrofin retitled this revision from to CMake: enable installing utils.
mtrofin updated this object.
mtrofin edited the test plan for this revision. (Show Details)
mtrofin added reviewers: jfb, dschuff.
mtrofin added a subscriber: Unknown Object (MLST).

LGTM, maybe Chris has a comment, as he's been working on CMake lately.

beanz added inline comments.Mar 25 2015, 11:08 AM
cmake/modules/AddLLVM.cmake
551

I would add COMPONENT arguments here to set the install component, and I would add custom install targets.

For an example see: AddLLVM.cmake:416-424.

mtrofin updated this revision to Diff 22677.Mar 25 2015, 1:57 PM
mtrofin edited edge metadata.

Incorporated feedback:

  • COMPONENT argument
  • custom install targets
beanz added inline comments.Mar 25 2015, 2:14 PM
cmake/modules/AddLLVM.cmake
554

Sorry to nitpick, but you want to wrap this in:

if (NOT CMAKE_CONFIGURATION_TYPES)

That way you won't be creating an unwieldy number of extra targets for IDE users.

I see. I didn't fully grasp that nuance, thanks for clarifying!

mtrofin updated this revision to Diff 22678.Mar 25 2015, 2:23 PM

Wrapped the custom install target

beanz accepted this revision.Mar 25 2015, 2:29 PM
beanz edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 25 2015, 2:29 PM
dschuff closed this revision.Mar 27 2015, 11:03 AM

Committed as r233385