This is an archive of the discontinued LLVM Phabricator instance.

Differential D8527

Refactor: Simplify boolean expressions in llvm IR
ClosedPublic

Authored by LegalizeAdulthood on Mar 22 2015, 1:08 PM.

Details

Reviewers
chandlerc
dblaikie
alexfh
• rafael
dexonsmith
void
Commits
rG9965c5ae14f1: Refactor: Simplify boolean expressions in llvm IR
rL233005: Refactor: Simplify boolean expressions in llvm IR
Summary

Simplify boolean expressions using true and false with clang-tidy

Diff Detail

Repository
rL LLVM

Event Timeline

LegalizeAdulthood updated this revision to Diff 22435.Mar 22 2015, 1:08 PM
LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean expressions in llvm IR.
LegalizeAdulthood updated this object.
LegalizeAdulthood edited the test plan for this revision. (Show Details)
LegalizeAdulthood added reviewers: alexfh, dexonsmith, void, • rafael, dblaikie, chandlerc.
LegalizeAdulthood added a subscriber: Unknown Object (MLST).
dblaikie edited edge metadata.Mar 23 2015, 12:54 PM

Looks good - committed in r233005

Closed by commit rL233005: Refactor: Simplify boolean expressions in llvm IR (authored by dblaikie). · Explain WhyMar 23 2015, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
IR/
50 lines

Diff 22509

llvm/trunk/lib/IR/Instructions.cpp

Show First 20 Lines • Show All 2,523 Lines • ▼ Show 20 Lines if (VectorType *DestVecTy = dyn_cast<VectorType>(DestTy))
} }
// Get the bit sizes, we'll need these // Get the bit sizes, we'll need these
unsigned SrcBits = SrcTy->getPrimitiveSizeInBits(); // 0 for ptr unsigned SrcBits = SrcTy->getPrimitiveSizeInBits(); // 0 for ptr
unsigned DestBits = DestTy->getPrimitiveSizeInBits(); // 0 for ptr unsigned DestBits = DestTy->getPrimitiveSizeInBits(); // 0 for ptr
// Run through the possibilities ... // Run through the possibilities ...
if (DestTy->isIntegerTy()) { // Casting to integral if (DestTy->isIntegerTy()) { // Casting to integral
if (SrcTy->isIntegerTy()) { // Casting from integral if (SrcTy->isIntegerTy()) // Casting from integral
return true; return true;
} else if (SrcTy->isFloatingPointTy()) { // Casting from floating pt if (SrcTy->isFloatingPointTy()) // Casting from floating pt
return true; return true;
} else if (SrcTy->isVectorTy()) { // Casting from vector if (SrcTy->isVectorTy()) // Casting from vector
return DestBits == SrcBits; return DestBits == SrcBits;
} else { // Casting from something else // Casting from something else
return SrcTy->isPointerTy(); return SrcTy->isPointerTy();
} }
} else if (DestTy->isFloatingPointTy()) { // Casting to floating pt if (DestTy->isFloatingPointTy()) { // Casting to floating pt
if (SrcTy->isIntegerTy()) { // Casting from integral if (SrcTy->isIntegerTy()) // Casting from integral
return true; return true;
} else if (SrcTy->isFloatingPointTy()) { // Casting from floating pt if (SrcTy->isFloatingPointTy()) // Casting from floating pt
return true; return true;
} else if (SrcTy->isVectorTy()) { // Casting from vector if (SrcTy->isVectorTy()) // Casting from vector
return DestBits == SrcBits; return DestBits == SrcBits;
} else { // Casting from something else // Casting from something else
return false; return false;
} }
} else if (DestTy->isVectorTy()) { // Casting to vector if (DestTy->isVectorTy()) // Casting to vector
return DestBits == SrcBits; return DestBits == SrcBits;
} else if (DestTy->isPointerTy()) { // Casting to pointer if (DestTy->isPointerTy()) { // Casting to pointer
if (SrcTy->isPointerTy()) { // Casting from pointer if (SrcTy->isPointerTy()) // Casting from pointer
return true;
} else if (SrcTy->isIntegerTy()) { // Casting from integral
return true; return true;
} else { // Casting from something else return SrcTy->isIntegerTy(); // Casting from integral
return false;
} }
} else if (DestTy->isX86_MMXTy()) { if (DestTy->isX86_MMXTy()) {
if (SrcTy->isVectorTy()) { if (SrcTy->isVectorTy())
return DestBits == SrcBits; // 64-bit vector to MMX return DestBits == SrcBits; // 64-bit vector to MMX
} else {
return false; return false;
} } // Casting to something else
} else { // Casting to something else
return false; return false;
} }
}
bool CastInst::isBitCastable(Type *SrcTy, Type *DestTy) { bool CastInst::isBitCastable(Type *SrcTy, Type *DestTy) {
if (!SrcTy->isFirstClassType() || !DestTy->isFirstClassType()) if (!SrcTy->isFirstClassType() || !DestTy->isFirstClassType())
return false; return false;
if (SrcTy == DestTy) if (SrcTy == DestTy)
return true; return true;
▲ Show 20 Lines • Show All 1,112 Lines • Show Last 20 Lines