This is an archive of the discontinued LLVM Phabricator instance.

[doxygen] Fix bad doxygen results for BugReporterVisitors.h
ClosedPublic

Authored by OikawaKirie on Aug 2 2020, 10:05 PM.

Details

Summary

Because of {@code xxxxx} will trigger a Doxygen bug. And as far as I am thinking, the bug may be matching the close brace with the open brace of the namespace declaration (namespace clang { or namespace ento {). With this patch, we can bypass the problem and successfully generate documents for the classes in BugReporterVisitors.h.

Diff Detail

Event Timeline

OikawaKirie created this revision.Aug 2 2020, 10:05 PM
OikawaKirie requested review of this revision.Aug 2 2020, 10:05 PM

Hey, thanks again for cleaning up the analyzer's docs šŸ˜„

clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
56

Maybe it is better to create a reference to this function using the \ref command?

OikawaKirie marked an inline comment as done.

Now it has a link to the getEndPath.

Awesome, thanks! Buuuut, maybe we can use \ref form, it looks like it's a preferred form in the codebase.

Ok, I got it. I will pay attention to this in the future submits.

@vsavchenko @NoQ
The patch has been updated as required. Is there anything I need to do with the patch?

clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
56

Yes, using \ref looks better. I will submit it again. To be similar to the original code, I will use @ref getEndPath instead.

vsavchenko accepted this revision.Aug 24 2020, 12:53 AM

Awesome! I will submit the patch!

This revision is now accepted and ready to land.Aug 24 2020, 12:53 AM
This revision was automatically updated to reflect the committed changes.