This is an archive of the discontinued LLVM Phabricator instance.

Don't use /implib when linking LLVM executables
AbandonedPublic

Authored by amccarth on Mar 18 2015, 2:12 PM.

Details

Reviewers
chandlerc
rnk
Summary

No import library is actually generated when linking the executables. Note that there was already code to do this for cywin and mingw.

This is a step toward eliminating the apparent circular dependency: lldb.lib (the fake import library) depends on lldb.exe, which depends on lldb.lib (the actual import library for (lib)lldb.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 22209.Mar 18 2015, 2:12 PM
amccarth retitled this revision from to Don't use /implib when linking LLVM executables.
amccarth updated this object.
amccarth edited the test plan for this revision. (Show Details)
amccarth added a reviewer: chandlerc.
amccarth added a subscriber: Unknown Object (MLST).

Honestly, Reid would be a much better reviewer here. I don't know enough about the windows options.

rnk edited edge metadata.Mar 24 2015, 9:17 AM

Is this still needed, or are we leaving liblldb alone and moving on with life?

cmake/modules/HandleLLVMOptions.cmake
463

I'd add a comment here saying that if we ever want to support loadable plugins on Windows, we should leave these flags alone.

Right now we don't support loadable plugins on Windows at all, so taking out these flags is fine.

amccarth abandoned this revision.Mar 24 2015, 11:40 AM

The need for this is gone, so I'll drop this.