This is an archive of the discontinued LLVM Phabricator instance.

Default to "nvptx[64]-unknown-cuda" triple for device-side CUDA compilation.
AbandonedPublic

Authored by tra on Mar 17 2015, 1:45 PM.

Details

Reviewers
eliben
echristo
Summary

Default to "nvptx[64]-unknown-cuda" triple for device-side CUDA compilation.

Diff Detail

Event Timeline

tra updated this revision to Diff 22120.Mar 17 2015, 1:45 PM
tra retitled this revision from to Default to "nvptx[64]-unknown-cuda" triple for device-side CUDA compilation..
tra updated this object.
tra edited the test plan for this revision. (Show Details)
tra added reviewers: eliben, echristo.
tra added a subscriber: Unknown Object (MLST).
eliben accepted this revision.Mar 18 2015, 8:00 AM
eliben edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 18 2015, 8:00 AM
echristo edited edge metadata.Mar 18 2015, 11:24 AM

Since -fcuda-is-device is just a -cc1 option can we require that the user just pass the triple in? Seems like a small shortcut that's unneeded?

-eric

tra abandoned this revision.Mar 18 2015, 2:28 PM

Scrapped. echristo@ has convinced me that required parameters to cc1 should not be guessed but rather provided explicitly.