This is an archive of the discontinued LLVM Phabricator instance.

Use TestClangConfig in AST Matchers tests and run them in more configurations
ClosedPublic

Authored by gribozavr on Jul 15 2020, 6:21 AM.

Details

Summary

I am changing tests for AST Matchers to run in multiple language standards
versions, and under multiple triples that have different behavior with regards
to templates. This change is similar to https://reviews.llvm.org/D82179.

To keep the size of the patch manageable, in this patch I'm only migrating one
file to get the process started and get feedback on this approach.

Diff Detail

Event Timeline

gribozavr created this revision.Jul 15 2020, 6:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2020, 6:21 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ymandel accepted this revision.Jul 16 2020, 6:14 AM

Thanks for doing this change! I think it's a great step forward for the testing robustness. I'm scared by how many fixme's we have in this file, but at least they're now explicit, rather than implicit. :)

This revision is now accepted and ready to land.Jul 16 2020, 6:14 AM
This revision was automatically updated to reflect the committed changes.