Fix for Bug 22880

[eszasip]

Summary

The misc-static-assert check will not warn on assert(false), assert(False), assert(FALSE); where false / False / FALSE are macros expanding to the false or 0 literals.

Also added corresponding test cases.

Bug 22880

[alexfh]

Looks good! I'll address the two issues and commit the patch.

Thank you for the fix!

clang-tidy/misc/StaticAssertCheck.cpp

86

Use StringRef::compare_lower here.

test/clang-tidy/misc-static-assert.cpp

16

Define one of these to 0 to test this option.

[alexfh]

Committed revision 232306.

clang-tidy/misc/StaticAssertCheck.cpp

     return;
 
   // False literal is not the result of macro expansion.
-  if (IsAlwaysFalse &&
-      !SM.getImmediateSpellingLoc(IsAlwaysFalse->getExprLoc()).isMacroID())
-    return;
+  if (IsAlwaysFalse) {
+    SourceLocation FalseLiteralLoc =
+        SM.getImmediateSpellingLoc(IsAlwaysFalse->getExprLoc());
+    if (!FalseLiteralLoc.isMacroID())
+      return;
+
+    StringRef FalseMacroName =
+        Lexer::getImmediateMacroName(FalseLiteralLoc, SM, Opts);
+    if (FalseMacroName == "false" || FalseMacroName == "False" ||
+        FalseMacroName == "FALSE")
+      return;
+  }
 
   SourceLocation AssertLoc = SM.getImmediateMacroCallerLoc(AssertExpansionLoc);
 

test/clang-tidy/misc-static-assert.cpp

 
 #define ZERO_MACRO 0
 
+#define False false
+#define FALSE false
+
 #define my_macro() assert(0 == 1)
 // CHECK-FIXES: #define my_macro() assert(0 == 1)
 

   assert(false);
   // CHECK-FIXES: {{^  }}assert(false);
 
+  assert(False);
+  // CHECK-FIXES: {{^  }}assert(False);
+  assert(FALSE);
+  // CHECK-FIXES: {{^  }}assert(FALSE);
+
   assert(ZERO_MACRO);
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be
   // CHECK-FIXES: {{^  }}static_assert(ZERO_MACRO, "");