This is an archive of the discontinued LLVM Phabricator instance.

[SCEV] Add a `scalar-evolution-print-constant-ranges' option
ClosedPublic

Authored by sanjoy on Mar 7 2015, 4:25 PM.

Details

Summary

Unused in this commit, but will be used in a subsequent change (D8142)
by a FileCheck test.

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy updated this revision to Diff 21437.Mar 7 2015, 4:25 PM
sanjoy retitled this revision from to [SCEV] Add a `scalar-evolution-print-constant-ranges' option.
sanjoy updated this object.
sanjoy edited the test plan for this revision. (Show Details)
sanjoy added a reviewer: atrick.
sanjoy added a subscriber: Unknown Object (MLST).
atrick accepted this revision.Mar 9 2015, 12:22 PM
atrick edited edge metadata.

LGTM.

How bad would it be to make this default? Just lots of tests to update? Or is it really undesirable to see this level of detail?

I'm not anxious to break tests and create merge problems for people. I'm just curious. Please explain why we need another command line option in the commit comments at least.

This revision is now accepted and ready to land.Mar 9 2015, 12:22 PM
sanjoy updated this revision to Diff 21511.Mar 9 2015, 2:09 PM
sanjoy edited edge metadata.

Changed ScalarEvolution::print to always print the constant ranges
associated with SCEVs. This did not create as much churn as I had
feared, PTAL.

atrick added a comment.Mar 9 2015, 2:11 PM

Thanks. I think it's better not to add options, even if it causes some merge headaches. Although I don't think many people have out-of-tree SCEV tests anyway.

This revision was automatically updated to reflect the committed changes.