Move Python Init from InitializeForLLGS to Initialize

[vharron]

Summary

Linux configure+make builds have ~175 tests failing that aren't
failing in cmake builds. The tests have error messages like
"'a.out' doesn't contain the architecture x86-64" ObjectFileELF
plugin wasn't loaded when this message was output.

I found ScriptInterpreterPython::InitializePrivate() is calling
Debugger::Terminate(), which terminates ObjectFileELF (and lots
of other stuff) setup earlier in the InitializeForLLGS.

So I moved python Init/Term from Init/TermForLLGS to Init/Term

[tberghammer]

Are you sure, that lldb-server don't use the ScriptInterpreterPython moduul?
If yes then it looks good to me, but I would suggest to add a reference counting to the [Initialize,Terminate]LLGS methods (possibly as a separate patch).

I think the behavior is different with cmake+ninja and with configure+make because one of them compiles with LLDB_DISABLE_PYTHON enabled while the other without it.

[flackr]

Can you verify that you're still able to launch a remote process? When I tried to remove the python initialization it failed on trying to run "process launch" to start the process on the remote llgs platform.

[tberghammer]

Accepted with follow up discussion in D8183

[clayborg]

Looks good.

[vharron]

Committed

source/lldb.cpp

#endif
         SystemRuntimeMacOSX::Initialize();
 
 #if defined (__APPLE__)
         SymbolVendorMacOSX::Initialize();
         DynamicLoaderDarwinKernel::Initialize();
         PlatformDarwinKernel::Initialize();
         ObjectFileMachO::Initialize();
 #endif
-
-#ifndef LLDB_DISABLE_PYTHON
-        ScriptInterpreterPython::InitializePrivate();
-        OperatingSystemPython::Initialize();
-#endif
     }
 }
 
 void
 lldb_private::Initialize ()
 {
     // Make sure we initialize only once
     static Mutex g_inited_mutex(Mutex::eMutexTypeRecursive);
     static bool g_inited = false;
 
     InitializeForLLGS();
     Mutex::Locker locker(g_inited_mutex);
     if (!g_inited)
     {
         g_inited = true;
+
+#ifndef LLDB_DISABLE_PYTHON
+        ScriptInterpreterPython::InitializePrivate();
+        OperatingSystemPython::Initialize();
+#endif
+
         // Initialize LLVM and Clang
         llvm::InitializeAllTargets();
         llvm::InitializeAllAsmPrinters();
         llvm::InitializeAllTargetMCs();
         llvm::InitializeAllDisassemblers();
 
         ABIMacOSX_i386::Initialize();
         ABIMacOSX_arm::Initialize();
lldb_private::TerminateLLGS ()
     SystemRuntimeMacOSX::Terminate();
 
 #if defined (__APPLE__)
     DynamicLoaderDarwinKernel::Terminate();
     ObjectFileMachO::Terminate();
     PlatformDarwinKernel::Terminate();
     SymbolVendorMacOSX::Terminate();
 #endif
-#ifndef LLDB_DISABLE_PYTHON
-    OperatingSystemPython::Terminate();
-#endif
 
     Log::Terminate();
 }
 
 void
 lldb_private::Terminate ()
 {
     Timer scoped_timer (__PRETTY_FUNCTION__, __PRETTY_FUNCTION__);

 #if defined (__FreeBSD__)
     ProcessFreeBSD::Terminate();
 #endif
     Debugger::SettingsTerminate ();
 
     PlatformRemoteGDBServer::Terminate();
     ProcessGDBRemote::Terminate();
     DynamicLoaderStatic::Terminate();
+
+#ifndef LLDB_DISABLE_PYTHON
+    OperatingSystemPython::Terminate();
+#endif
+
     TerminateLLGS();
 }
 
 #if defined (__APPLE__)
 extern "C" const unsigned char liblldb_coreVersionString[];
 #else
 
 #include "clang/Basic/Version.h"