Page MenuHomePhabricator

Fix expectation for TestPlatformCommand.test_shell
ClosedPublic

Authored by tberghammer on Mar 3 2015, 5:05 AM.

Details

Summary

Fix expectation for TestPlatformCommand.test_shell

  • Create expectation based on target platform
  • Add custom expectation for remote android target

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer updated this revision to Diff 21096.Mar 3 2015, 5:05 AM
tberghammer retitled this revision from to Fix expectation for TestPlatformCommand.test_shell.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added reviewers: zturner, clayborg.
tberghammer added a subscriber: Unknown Object (MLST).
vharron requested changes to this revision.Mar 3 2015, 7:54 AM
vharron added a reviewer: vharron.
vharron added a subscriber: vharron.
vharron added inline comments.
test/functionalities/platform/TestPlatformCommand.py
37 ↗(On Diff #21096)

I think that you should refactored into a function, maybe based off of compiler's target triple?

vharron-macbookpro:test vharron$ clang -target x86_64--linux-gnu --version
Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn)
Target: x86_64--linux-gnu
Thread model: posix

vharron@tifa:~/ll/svn/lldb/test$ gcc -m32 -print-multiarch
i386-linux-gnu

This revision now requires changes to proceed.Mar 3 2015, 7:54 AM

It can be based on compiler triple or platform_name but it should abstract local/remote targets.

tberghammer updated this revision to Diff 21109.Mar 3 2015, 8:54 AM
tberghammer edited edge metadata.

Use the target triple to get the expectations

zturner edited edge metadata.Mar 3 2015, 9:20 AM

Windows stuff looks good

clayborg accepted this revision.Mar 3 2015, 9:47 AM
clayborg edited edge metadata.

Looks good.

This revision was automatically updated to reflect the committed changes.